feat: Add random binary and octal number generation #191
Conversation
|
✔️ Deploy Preview for vigilant-wescoff-04e480 ready! 🔨 Explore the source changes: c8b0625 🔍 Inspect the deploy log: https://app.netlify.com/sites/vigilant-wescoff-04e480/deploys/61e77b26c7a2e90008e8ed85 😎 Browse the preview: https://deploy-preview-191--vigilant-wescoff-04e480.netlify.app |
src/datatype.ts
Outdated
| * @param count defaults to 1 | ||
| */ | ||
| octal(count: number = 1): string { | ||
| let wholeString = ''; |
There was a problem hiding this comment.
| let wholeString = ''; | |
| let octalString = ''; |
src/datatype.ts
Outdated
| * @param count defaults to 1 | ||
| */ | ||
| binary(count: number = 1): string { | ||
| let wholeString = ''; |
There was a problem hiding this comment.
| let wholeString = ''; | |
| let binaryString = ''; |
test/datatype.unit.js
Outdated
|
|
||
| it('generates a random binary string', function () { | ||
| var hex = binary(12); | ||
| assert.ok(hex.match(/^(0b)[01]+$/i)); |
There was a problem hiding this comment.
| assert.ok(hex.match(/^(0b)[01]+$/i)); | |
| assert.ok(hex.match(/^0b[01]{12}$/i)); |
test/datatype.unit.js
Outdated
|
|
||
| it('generates a single binary charcter when no additional argument is provided', function () { | ||
| var binaryNum = binary(); | ||
| assert.ok(binaryNum.match(/^(0b)[01]{1}$/i)); |
There was a problem hiding this comment.
| assert.ok(binaryNum.match(/^(0b)[01]{1}$/i)); | |
| assert.ok(binaryNum.match(/^0b[01]$/i)); |
src/datatype.ts
Outdated
| * @method faker.datatype.octal | ||
| * @param count defaults to 1 | ||
| */ | ||
| octal(count: number = 1): string { |
There was a problem hiding this comment.
I'd suggest length, but it's OK for consistency with hexaDecimal.
There was a problem hiding this comment.
I agree, I'll update this
…gth of returned string matches provided argument
… instead of `count`
src/datatype.ts
Outdated
| */ | ||
| hexaDecimal(count: number = 1): string { | ||
| hexaDecimal(length: number = 1): string { | ||
| let wholeString = ''; |
There was a problem hiding this comment.
Maybe hexaString too? It's very minor though.
|
We're starting work on the |
Shinigami92
modified the milestones:
v6.2 - New small features,
v6 - Non-Breaking Changes
|
Could we also provide a version without the Buffer.from(faker.datatype.hexadecimal(20).substring(2), 'hex') |
Don't have to much time yet to go into details and I have other prios right now, but yes I would like to not prefix it by default at all but have just the option to add the prefix on demand via an option argument. Consistent for all of these functions! => #954 |
|
I will close this PR since it's heavily outdated. I suggest opening another PR that at least has the 'new' test strategy and directory structure implemented. If anyone really wants to keep this alive, feel free to reopen it. |
closes #184