Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(locale): correct capitalization of last_name in en_AU #1912

Merged
merged 1 commit into from
Mar 8, 2023

Conversation

matthewmayer
Copy link
Contributor

e.g. O'reilly => O'Reilly

@matthewmayer matthewmayer requested a review from a team as a code owner March 7, 2023 17:30
@matthewmayer matthewmayer self-assigned this Mar 7, 2023
ST-DDT
ST-DDT previously approved these changes Mar 7, 2023
@ST-DDT
Copy link
Member

ST-DDT commented Mar 7, 2023

Please fix the conflicts.

@ST-DDT ST-DDT added needs rebase There is a merge conflict p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug c: locale Permutes locale definitions m: person Something is referring to the person module labels Mar 7, 2023
@codecov
Copy link

codecov bot commented Mar 8, 2023

Codecov Report

Merging #1912 (e2a7443) into next (7ae5cdb) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #1912      +/-   ##
==========================================
- Coverage   99.63%   99.62%   -0.02%     
==========================================
  Files        2356     2356              
  Lines      236563   236563              
  Branches     1196     1190       -6     
==========================================
- Hits       235698   235671      -27     
- Misses        843      870      +27     
  Partials       22       22              
Impacted Files Coverage Δ
src/locales/en_AU/person/last_name.ts 100.00% <100.00%> (ø)
src/modules/internet/user-agent.ts 87.57% <0.00%> (-8.29%) ⬇️
src/modules/system/index.ts 99.74% <0.00%> (-0.26%) ⬇️
src/modules/location/index.ts 98.92% <0.00%> (+0.21%) ⬆️

@ST-DDT ST-DDT removed the needs rebase There is a merge conflict label Mar 8, 2023
@ST-DDT ST-DDT requested review from a team March 8, 2023 07:54
@ST-DDT ST-DDT merged commit 4f14533 into faker-js:next Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: locale Permutes locale definitions m: person Something is referring to the person module p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants