fix(location): no leading zero on building number or secondary address

[matthewmayer]

fix #2031

Note this only affects default en locale. Similar approach could be taken in other locales which have building_number patterns

[codecov]

Codecov Report

Merging #2032 (d6ad01b) into next (a94d365) will increase coverage by 0.00%.
The diff coverage is 88.88%.

Additional details and impacted files

@@           Coverage Diff           @@
##             next    #2032   +/-   ##
=======================================
  Coverage   99.59%   99.59%           
=======================================
  Files        2567     2567           
  Lines      243388   243394    +6     
  Branches     1251     1253    +2     
=======================================
+ Hits       242404   242417   +13     
+ Misses        957      950    -7     
  Partials       27       27           

Impacted Files	Coverage Δ
src/definitions/location.ts	0.00% <0.00%> (ø)
src/modules/location/index.ts	99.02% <100.00%> (+<0.01%)	⬆️

... and 1 file with indirect coverage changes

[ST-DDT]

IMO instead of doing this strange pattern duplication stuff we should rather change the implementation to not use replacewithnumber and instead use a simple regex replace with numeric without leading zero or something.

[ST-DDT]

Team Decision

• We will implement this via arrayElement(patterns).replace(/#+/g, (m) => string.numeric(m.length)
• The locale definition documentation will be extended to explicitly mention the # -> number transformation
• We will add a test that checks that it will not return leading zeros

See #2031 (comment)

@matthewmayer Will you update your PR or start a new one?

[matthewmayer]

Would it also make sense to apply this for secondary address? To avoid "Apt 000" in en or '3/0' in pl etc.

[matthewmayer]

Would it also make sense to apply this for secondary address? To avoid "Apt 000" in en or '3/0' in pl etc.

in this PR or a seperate PR?

[ST-DDT]

in this PR or a seperate PR?

Since it does the exact same thing for related stuff, I am fine with doing it in one PR.
Not sure what the others think though.

The PR title needs to be adjusted anyway.