refactor(location): deprecate cityName

[xDivisionByZerox]

Part of #2021.

[codecov]

Codecov Report

❗ No coverage uploaded for pull request base (next@2a6f578). Click here to learn what that means.
The diff coverage is 100.00%.

❗ Current head eaa21fa differs from pull request most recent head 89c38cc. Consider uploading reports for the commit 89c38cc to get more accurate results

Additional details and impacted files

@@           Coverage Diff           @@
##             next    #2070   +/-   ##
=======================================
  Coverage        ?   99.61%           
=======================================
  Files           ?     2535           
  Lines           ?   242211           
  Branches        ?     1293           
=======================================
  Hits            ?   241274           
  Misses          ?      910           
  Partials        ?       27           

Impacted Files	Coverage Δ
src/modules/random/index.ts	100.00% <ø> (ø)
src/modules/location/index.ts	99.17% <100.00%> (ø)

[ST-DDT]

The other PR #2051 also adjusts the locale data.

[xDivisionByZerox]

The other PR #2051 also adjusts the locale data.

I know but wanted to prevent merge conflicts as well as breaking changes in THIS PR. I had a really hard time actually finding the deprecation itself in the other PR.

[matthewmayer]

Do you plan to make city and cityName return the same data in v8.0? Or you just deprecate cityName in v8.0 and merge the locale data in v9?

[xDivisionByZerox]

This is the same as #2051.
location.city already is a superset of location.cityName. As described in #2021 (comment) we simply deprecate the *Name implementation for now. We can think about adding a generated option parameter (to only get generated or real cities) in the future if the community requests.