Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(locale): remove incorrect and unused city_prefix/suffix for sk #2117

Merged
merged 2 commits into from
May 2, 2023

Conversation

matthewmayer
Copy link
Contributor

Not used in city_patterns, and are copy-paste of English prefixes and
suffixes, not in sk.

@matthewmayer matthewmayer requested a review from a team as a code owner May 2, 2023 01:57
@matthewmayer matthewmayer added p: 1-normal Nothing urgent c: locale Permutes locale definitions m: location Something is referring to the location module labels May 2, 2023
@matthewmayer matthewmayer self-assigned this May 2, 2023
@codecov
Copy link

codecov bot commented May 2, 2023

Codecov Report

Merging #2117 (4e9f346) into next (7f9e9df) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #2117      +/-   ##
==========================================
- Coverage   99.60%   99.60%   -0.01%     
==========================================
  Files        2605     2605              
  Lines      244968   244949      -19     
  Branches     1256     1255       -1     
==========================================
- Hits       243998   243970      -28     
- Misses        943      952       +9     
  Partials       27       27              
Impacted Files Coverage Δ
src/locales/sk/location/city_prefix.ts 100.00% <100.00%> (ø)
src/locales/sk/location/city_suffix.ts 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

@ST-DDT ST-DDT requested review from a team May 2, 2023 06:54
@ST-DDT ST-DDT added the s: accepted Accepted feature / Confirmed bug label May 2, 2023
@ST-DDT ST-DDT merged commit e094a5a into faker-js:next May 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: locale Permutes locale definitions m: location Something is referring to the location module p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants