-
-
Notifications
You must be signed in to change notification settings - Fork 932
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(location): avoid hyphenated surnames in city patterns #2119
Merged
ST-DDT
merged 7 commits into
faker-js:next
from
matthewmayer:fix/avoid-hyphenation-in-cities
Jul 20, 2023
Merged
fix(location): avoid hyphenated surnames in city patterns #2119
ST-DDT
merged 7 commits into
faker-js:next
from
matthewmayer:fix/avoid-hyphenation-in-cities
Jul 20, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewmayer
added
p: 1-normal
Nothing urgent
c: locale
Permutes locale definitions
m: location
Something is referring to the location module
labels
May 2, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## next #2119 +/- ##
========================================
Coverage 99.59% 99.60%
========================================
Files 2638 2631 -7
Lines 244685 245567 +882
Branches 1081 1155 +74
========================================
+ Hits 243698 244587 +889
+ Misses 960 953 -7
Partials 27 27
|
import-brain
previously approved these changes
May 3, 2023
xDivisionByZerox
previously approved these changes
May 4, 2023
ST-DDT
previously approved these changes
May 4, 2023
Shinigami92
previously approved these changes
May 4, 2023
import-brain
previously approved these changes
May 4, 2023
matthewmayer
dismissed stale reviews from xDivisionByZerox, import-brain, Shinigami92, and ST-DDT
via
June 17, 2023 13:23
bdc170c
xDivisionByZerox
approved these changes
Jun 29, 2023
import-brain
approved these changes
Jun 30, 2023
ST-DDT
approved these changes
Jul 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
c: locale
Permutes locale definitions
m: location
Something is referring to the location module
p: 1-normal
Nothing urgent
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes city_patterns to use person.last_name instead of person.lastName. This means it uses the definitions directly, not the method, which avoids using hyphenated and double surnames in locales where those are used which were introduced in #1872
e.g. remove city names like
Newton Morissette-Kovacekwell
Pollich-Douglasville
Note this doesn't affect default
en
locale as that is already using last_name instead of lastName https://github.com/faker-js/faker/blob/e490ed3e505124585857421cac73d6f8418280aa/src/locales/en/location/city_pattern.ts