Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(helpers): new method objectEntry #2123

Merged
merged 4 commits into from
May 3, 2023
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions src/modules/helpers/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -797,6 +797,25 @@ export class HelpersModule {
return object[key];
}

/**
* Returns a random [key, value] pair from given object or throws an Error if no key could be found.
suyashgulati marked this conversation as resolved.
Show resolved Hide resolved
suyashgulati marked this conversation as resolved.
Show resolved Hide resolved
*
* @template T The type of the object to select from.
*
* @param object The object to be used.
*
* @example
* faker.helpers.objectEntry({ prop1: 'value1', prop2: 'value2' }) // ['prop1', 'value1']
*
* @since 8.0.0
suyashgulati marked this conversation as resolved.
Show resolved Hide resolved
*/
objectEntry<T extends Record<string, unknown>>(
object: T
): [keyof T, T[keyof T]] {
const key = this.faker.helpers.objectKey(object);
return [key, object[key]];
}

/**
* Returns random element from the given array.
*
Expand Down
21 changes: 21 additions & 0 deletions test/__snapshots__/helpers.spec.ts.snap
Original file line number Diff line number Diff line change
Expand Up @@ -110,6 +110,13 @@ exports[`helpers > 42 > mustache > template with method 1`] = `"Hello John!"`;

exports[`helpers > 42 > mustache > template with string 1`] = `"Hello John!"`;

exports[`helpers > 42 > objectEntry > simple 1`] = `
[
"b",
2,
]
`;

exports[`helpers > 42 > objectKey > simple 1`] = `"b"`;

exports[`helpers > 42 > objectValue > simple 1`] = `2`;
Expand Down Expand Up @@ -343,6 +350,13 @@ exports[`helpers > 1211 > mustache > template with method 1`] = `"Hello John!"`;

exports[`helpers > 1211 > mustache > template with string 1`] = `"Hello John!"`;

exports[`helpers > 1211 > objectEntry > simple 1`] = `
[
"c",
3,
]
`;

exports[`helpers > 1211 > objectKey > simple 1`] = `"c"`;

exports[`helpers > 1211 > objectValue > simple 1`] = `3`;
Expand Down Expand Up @@ -558,6 +572,13 @@ exports[`helpers > 1337 > mustache > template with method 1`] = `"Hello John!"`;

exports[`helpers > 1337 > mustache > template with string 1`] = `"Hello John!"`;

exports[`helpers > 1337 > objectEntry > simple 1`] = `
[
"a",
1,
]
`;

exports[`helpers > 1337 > objectKey > simple 1`] = `"a"`;

exports[`helpers > 1337 > objectValue > simple 1`] = `1`;
Expand Down
25 changes: 25 additions & 0 deletions test/helpers.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -157,6 +157,10 @@ describe('helpers', () => {
t.it('simple', { a: 1, b: 2, c: 3 });
});

t.describe('objectEntry', (t) => {
t.it('simple', { a: 1, b: 2, c: 3 });
});

t.describe('fake', (t) => {
t.it('with empty string', '')
.it('with a static template', 'my test string')
Expand Down Expand Up @@ -935,6 +939,27 @@ describe('helpers', () => {
});
});

describe('objectEntry', () => {
it('should return a random key, value pair', () => {
const testObject = {
hello: 'to',
you: 'my',
friend: '!',
};
const [key, value] = faker.helpers.objectEntry(testObject);

expect(Object.keys(testObject)).toContain(key);
expect(Object.values(testObject)).toContain(value);
expect(testObject[key]).toEqual(value);
});

it('should throw if given object is empty', () => {
expect(() => faker.helpers.objectEntry({})).toThrowError(
new FakerError('Cannot get value from empty dataset.')
);
});
});

describe('fake()', () => {
it('does allow empty string input', () => {
const actual = faker.helpers.fake('');
Expand Down