feat(location): add ne postcodes #2148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nepali postcodes are 5 digits starting with [1-5]
matthewmayer
added
c: locale
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## next #2148 +/- ##
=======================================
Coverage 99.60% 99.60%
=======================================
Files 2620 2621 +1
Lines 245472 245476 +4
Branches 1154 1158 +4
=======================================
+ Hits 244493 244515 +22
+ Misses 952 934 -18
Partials 27 27
|
ST-DDT
approved these changes
May 11, 2023
xDivisionByZerox
approved these changes
Jun 3, 2023
There was a problem hiding this comment.
I wasn't really able to figure out the zip codes from the source you provided.
https://www.nepalitrends.com/list-of-postal-codes-of-nepal/ did help me tho. Additionally, it has a full table of all possible postcodes, as the current templates could generate some invalid zip codes. But it's good enough IMO.
ejcheng
approved these changes
Jun 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nepali postcodes are 5 digits starting with [1-5]
https://www.gpo.gov.np/Home/Postalcode