Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(locale): limited ja first names without passing sex #2190

Merged
merged 3 commits into from
Jun 4, 2023
Merged

fix(locale): limited ja first names without passing sex #2190

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
850c286
fix(locale): limited ja first names candidates without passing sex
KeisukeYamashita May 31, 2023
0508a6a
Merge branch 'next' into local/ja/fix-limited-first-name
ST-DDT Jun 1, 2023
07a5a3e
Merge branch 'next' into local/ja/fix-limited-first-name
ST-DDT Jun 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 8 additions & 23 deletions src/locales/ja/person/first_name.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,23 +1,8 @@
export default [
'大翔',
'蓮',
'颯太',
'樹',
'大和',
'陽翔',
'陸斗',
'太一',
'海翔',
'蒼空',
'翼',
'陽菜',
'結愛',
'結衣',
'杏',
'莉子',
'美羽',
'結菜',
'心愛',
'愛菜',
'美咲',
];
// We don't have a generic first name list for this locale
// So simply concatenate male and female lists and remove any duplicates
// This avoids falling back to fallback locale
import { mergeArrays } from './../../../internal/merge';
import female_first_name from './female_first_name';
import male_first_name from './male_first_name';

export default mergeArrays(female_first_name, male_first_name);