Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(locale): add Esperanto #2230

Merged
merged 29 commits into from
Aug 26, 2023
Merged

feat(locale): add Esperanto #2230

merged 29 commits into from
Aug 26, 2023

Conversation

RobinvanderVliet
Copy link
Contributor

@RobinvanderVliet RobinvanderVliet commented Jul 1, 2023

This pull request is ready to be merged!

Feedback and reviews are welcome and appreciated! This is my first merge request.

@RobinvanderVliet RobinvanderVliet requested a review from a team July 1, 2023 00:40
@RobinvanderVliet RobinvanderVliet requested a review from a team as a code owner July 1, 2023 00:40
@ejcheng ejcheng added the c: locale Permutes locale definitions label Jul 1, 2023
@xDivisionByZerox xDivisionByZerox added c: feature Request for new feature p: 1-normal Nothing urgent labels Jul 1, 2023
@RobinvanderVliet RobinvanderVliet marked this pull request as draft July 2, 2023 15:06
@codecov
Copy link

codecov bot commented Jul 3, 2023

Codecov Report

Merging #2230 (1b82ea8) into next (b103c63) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##             next    #2230     +/-   ##
=========================================
  Coverage   99.59%   99.59%             
=========================================
  Files        2665     2721     +56     
  Lines      246448   248549   +2101     
  Branches     1079     1078      -1     
=========================================
+ Hits       245454   247547   +2093     
- Misses        967      975      +8     
  Partials       27       27             
Files Changed Coverage Δ
src/locale/eo.ts 100.00% <100.00%> (ø)
src/locale/index.ts 100.00% <100.00%> (ø)
src/locales/eo/animal/bear.ts 100.00% <100.00%> (ø)
src/locales/eo/animal/crocodilia.ts 100.00% <100.00%> (ø)
src/locales/eo/animal/index.ts 100.00% <100.00%> (ø)
src/locales/eo/animal/lion.ts 100.00% <100.00%> (ø)
src/locales/eo/animal/type.ts 100.00% <100.00%> (ø)
src/locales/eo/color/human.ts 100.00% <100.00%> (ø)
src/locales/eo/color/index.ts 100.00% <100.00%> (ø)
src/locales/eo/commerce/index.ts 100.00% <100.00%> (ø)
... and 48 more

... and 2 files with indirect coverage changes

@RobinvanderVliet RobinvanderVliet marked this pull request as ready for review August 14, 2023 20:48
ST-DDT
ST-DDT previously approved these changes Aug 15, 2023
@ST-DDT ST-DDT requested review from a team August 15, 2023 15:15
ST-DDT
ST-DDT previously approved these changes Aug 20, 2023
@ST-DDT ST-DDT requested a review from a team August 20, 2023 06:24
@ST-DDT
Copy link
Member

ST-DDT commented Aug 20, 2023

For future PRs: please do one category of locale data (e.g. person) or ~< 20 files at a time unless necessary.
As that makes the PRs less time consuming to review in full.

@RobinvanderVliet
Copy link
Contributor Author

For future PRs: please do one category of locale data (e.g. person) or ~< 20 files at a time unless necessary. As that makes the PRs less time consuming to review in full.

Thank you for the suggestion, I will remember it for my next pull request! I created some more files for the Esperanto locale, which I will submit in my next merge request, after this one gets merged.

@ST-DDT ST-DDT changed the title feat(locale): Add Esperanto feat(locale): add Esperanto Aug 26, 2023
@ST-DDT ST-DDT enabled auto-merge (squash) August 26, 2023 12:23
@ST-DDT ST-DDT merged commit d91057d into faker-js:next Aug 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: feature Request for new feature c: locale Permutes locale definitions p: 1-normal Nothing urgent
Projects
No open projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

6 participants