Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(lorem): merge supplemental into words #2242

Merged
merged 8 commits into from
Jul 17, 2023
Merged

refactor(lorem): merge supplemental into words #2242

merged 8 commits into from
Jul 17, 2023

Conversation

matthewmayer
Copy link
Contributor

fix #2153

  • en: merge supplemental into words, sort and unique
  • he: deleted, as it was only latin words, but the he words list is Hebrew
  • dv: deleted, as identical to main words list
  • ur: merge supplemental into words, and unique
  • ja: merge supplemental into words
  • lv: merge supplemental into words, sort and unique

@matthewmayer
refactor(lorem): merge supplemental into words
88e630b 
fix faker-js#2153

- en: merge supplemental into words, sort and unique
- he: deleted, as it was only latin words, but the he words list is Hebrew
- dv: deleted, as identical to main words list
- ur: merge supplemental into words, and unique
- ja: merge supplemental into words
- lv: merge supplemental into words, sort and unique
@matthewmayer matthewmayer requested a review from a team as a code owner July 6, 2023 14:19
@matthewmayer matthewmayer added p: 1-normal Nothing urgent c: refactor PR that affects the runtime behavior, but doesn't add new features or fixes bugs m: lorem Something is referring to the lorem module labels Jul 6, 2023
@matthewmayer matthewmayer self-assigned this Jul 6, 2023
ST-DDT
ST-DDT reviewed Jul 9, 2023
View reviewed changes
src/locales/en/lorem/words.ts Show resolved Hide resolved
src/locales/ja/lorem/words.ts Show resolved Hide resolved
src/locales/lv/lorem/words.ts Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Jul 9, 2023 •
edited
Loading

Codecov Report

Merging #2242 (5992589) into next (ac9f5d2) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files 
@@           Coverage Diff            @@
##             next    #2242    +/-   ##
========================================
  Coverage   99.60%   99.60%            
========================================
  Files        2643     2637     -6     
  Lines      245862   244872   -990     
  Branches     1157     1160     +3     
========================================
- Hits       244880   243900   -980     
+ Misses        955      945    -10     
  Partials       27       27
Impacted Files Coverage Δ
src/locales/dv/lorem/index.ts 100.00% <ø> (ø)
src/locales/en/lorem/index.ts 100.00% <ø> (ø)
src/locales/he/lorem/index.ts 100.00% <ø> (ø)
src/locales/ja/lorem/index.ts 100.00% <ø> (ø)
src/locales/lv/lorem/index.ts 100.00% <ø> (ø)
src/locales/ur/lorem/index.ts 100.00% <ø> (ø)
src/locales/en/lorem/words.ts 100.00% <100.00%> (ø)
src/locales/ja/lorem/words.ts 100.00% <100.00%> (ø)
src/locales/lv/lorem/words.ts 100.00% <100.00%> (ø)
src/locales/ur/lorem/words.ts 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

@matthewmayer matthewmayer requested a review from ST-DDT July 10, 2023 09:32
@ST-DDT ST-DDT requested review from a team July 10, 2023 23:35
@ST-DDT ST-DDT enabled auto-merge (squash) July 17, 2023 20:17
@ST-DDT ST-DDT merged commit a3a1480 into faker-js:next Jul 17, 2023
@ST-DDT ST-DDT mentioned this pull request Jul 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xDivisionByZerox xDivisionByZerox xDivisionByZerox approved these changes

@ST-DDT ST-DDT ST-DDT approved these changes

Assignees

@matthewmayer matthewmayer

Labels
c: refactor PR that affects the runtime behavior, but doesn't add new features or fixes bugs m: lorem Something is referring to the lorem module p: 1-normal Nothing urgent
Projects
None yet
Milestone
v8.x
Development

Successfully merging this pull request may close these issues.

lorem: Merge "supplemental" with "words" list
3 participants
@matthewmayer @ST-DDT @xDivisionByZerox