Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

infra: ignore .pnpm-store #2253

Merged
merged 1 commit into from
Jul 15, 2023
Merged

infra: ignore .pnpm-store #2253

merged 1 commit into from
Jul 15, 2023

Conversation

Shinigami92
Copy link
Member

When using corepack and having a local .pnpm-store/ folder, prettier wants to format the content
This prevents prettier from doing that

@Shinigami92 Shinigami92 added the c: infra Changes to our infrastructure or project setup label Jul 15, 2023
@Shinigami92 Shinigami92 requested a review from a team as a code owner July 15, 2023 08:12
@Shinigami92 Shinigami92 self-assigned this Jul 15, 2023
@Shinigami92 Shinigami92 requested a review from a team July 15, 2023 08:12
Copy link
Member

@ST-DDT ST-DDT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why would the pnpm store folder be inside the project?

@codecov
Copy link

codecov bot commented Jul 15, 2023

Codecov Report

Merging #2253 (6f45369) into next (0708eb4) will decrease coverage by 0.01%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #2253      +/-   ##
==========================================
- Coverage   99.60%   99.59%   -0.01%     
==========================================
  Files        2643     2643              
  Lines      245862   245862              
  Branches     1159     1156       -3     
==========================================
- Hits       244883   244875       -8     
- Misses        952      960       +8     
  Partials       27       27              

see 2 files with indirect coverage changes

@Shinigami92
Copy link
Member Author

Why would the pnpm store folder be inside the project?

Because of executing statements like this: pnpm config set store-dir .pnpm-store
Source: https://pnpm.io/continuous-integration#gitlab-ci

@ST-DDT ST-DDT merged commit e550392 into next Jul 15, 2023
@ST-DDT ST-DDT deleted the dont-format-pnpm-store branch July 15, 2023 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: infra Changes to our infrastructure or project setup
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants