fix(image): dataUri is not random

[OmkarPednekar]

If color option is not provided the code will use a randomly generated color code as default color
the fix(module):faker.image.dataUri commit is the final one. where I have used faker.color.rgb in the previous commit I was using a for loop to generate a hex code. @ST-DDT suggested me to use the inbuilt functions so that we have reproducible values.

fixes #2307

[codecov]

Codecov Report

Merging #2316 (74925a0) into next (82b779d) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Additional details and impacted files

@@            Coverage Diff             @@
##             next    #2316      +/-   ##
==========================================
- Coverage   99.61%   99.60%   -0.01%     
==========================================
  Files        2793     2793              
  Lines      251586   251586              
  Branches     1100     1096       -4     
==========================================
- Hits       250611   250597      -14     
- Misses        948      962      +14     
  Partials       27       27              

Files Changed	Coverage Δ
src/modules/image/index.ts	100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

[ST-DDT]

I just noticed, that dataUri doesn't have seeded tests, so I created a PR for that.

Blocked by:

• test(image): add seeded tests for dataUri #2317

[OmkarPednekar]

is this okay?

[ST-DDT]

is this okay?

I would probably phrase it like this:

The background color of the image. Must be a color supported by svg. Defaults to a random color.

[OmkarPednekar]

Okay

[OmkarPednekar]

Please Check

[OmkarPednekar]

Made the changes in @param as well

[OmkarPednekar]

Updated the Docs

[Shinigami92]

👀

test failures

[OmkarPednekar]

Why are these tests failing?

[ST-DDT]

I fixed the random seeded tests using test snapshots.

[ST-DDT]

Why are these tests failing?

Because the randomized tests used snapshots which would work fine if the result is static, but this PR changes them to be random thus failing the tests. I fixed them by not using the static snapshots and instead check via validatorjs's isDataUri.

[OmkarPednekar]

Why are these tests failing?

Because the randomized tests used snapshots which would work fine if the result is static, but this PR changes them to be random thus failing the tests. I fixed them by not using the static snapshots and instead check via validatorjs's isDataUri.

But I had removed those test cases and changed them to match the changes

[ST-DDT]

But I had removed those test cases and changed them to match the changes

#2273 added new ones.

• feat(image): add image dataUri with base64 #2273

[OmkarPednekar]

But I had removed those test cases and changed them to match the changes

#2273 added new ones.

• feat(image): add image dataUri with base64 #2273

Oh I seee so how can we fix this failing tests?

[ST-DDT]

Oh I seee so how can we fix this failing tests?

I already removed/fixed them.

[OmkarPednekar]

Oh I seee so how can we fix this failing tests?

I already removed/fixed them.

No I meant the merge checks

[ST-DDT]

No I meant the merge checks

Not sure what you are referring to.

[OmkarPednekar]

No I meant the merge checks

Not sure what you are referring to.

Oh whatt just a moment ago they were appearing failed lol