Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(location): Dutch postal codes can never start with '0' #2326

Merged
merged 3 commits into from
Aug 26, 2023
Merged

fix(location): Dutch postal codes can never start with '0' #2326

merged 3 commits into from
Aug 26, 2023

Conversation

RobinvanderVliet
Copy link
Contributor

No description provided.

@RobinvanderVliet RobinvanderVliet requested a review from a team as a code owner August 20, 2023 15:36
@codecov
Copy link

codecov bot commented Aug 20, 2023

Codecov Report

Merging #2326 (a68af19) into next (3c839bf) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head a68af19 differs from pull request most recent head 88cfe0f. Consider uploading reports for the commit 88cfe0f to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #2326      +/-   ##
==========================================
- Coverage   99.60%   99.59%   -0.01%     
==========================================
  Files        2665     2665              
  Lines      246438   246448      +10     
  Branches     1086     1080       -6     
==========================================
- Hits       245468   245454      -14     
- Misses        943      967      +24     
  Partials       27       27              
Files Changed Coverage Δ
src/locales/nl/location/postcode.ts 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

@ST-DDT ST-DDT added p: 1-normal Nothing urgent c: locale Permutes locale definitions m: location Something is referring to the location module labels Aug 21, 2023
@ST-DDT
Copy link
Member

ST-DDT commented Aug 21, 2023

If you fix something please include a link that can be used for verification if possible.

@ST-DDT ST-DDT requested review from a team August 21, 2023 06:28
@import-brain
Copy link
Member

If you fix something please include a link that can be used for verification if possible.

Not too sure if this is good enough verification but it's what I found: https://stackoverflow.com/questions/17898523/regular-expression-for-dutch-zip-postal-code#:~:text=As%20an%20aside%3A%20Dutch%20postal%20codes%20never%20start%20with%20a%20zero.

@ST-DDT
Copy link
Member

ST-DDT commented Aug 21, 2023

If you fix something please include a link that can be used for verification if possible.

Not too sure if this is good enough verification but it's what I found: stackoverflow.com/questions/17898523/regular-expression-for-dutch-zip-postal-code#:~:text=As%20an%20aside%3A%20Dutch%20postal%20codes%20never%20start%20with%20a%20zero.

Well, there is always https://github.com/validatorjs/validator.js/blob/master/src/lib/isPostalCode.js

@matthewmayer
Copy link
Contributor

Wikipedia generally explains postcodes well

https://en.wikipedia.org/wiki/Postal_codes_in_the_Netherlands?wprov=sfti1

@ST-DDT ST-DDT enabled auto-merge (squash) August 26, 2023 11:46
@ST-DDT ST-DDT merged commit f195e06 into faker-js:next Aug 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: locale Permutes locale definitions m: location Something is referring to the location module p: 1-normal Nothing urgent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants