Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module): add new notations module for science #2415

Open
wants to merge 16 commits into
base: next
Choose a base branch
from

Conversation

CoolPlayLin
Copy link
Contributor

@CoolPlayLin CoolPlayLin commented Sep 23, 2023

@CoolPlayLin CoolPlayLin marked this pull request as ready for review September 23, 2023 05:41
@CoolPlayLin CoolPlayLin requested a review from a team as a code owner September 23, 2023 05:41
@CoolPlayLin CoolPlayLin changed the title Add new notations science feat(module): add new notations science Sep 23, 2023
@CoolPlayLin CoolPlayLin changed the title feat(module): add new notations science feat(module): add new notations module for science Sep 23, 2023
@matthewmayer
Copy link
Contributor

You should make a matching issue for this PR so that we can gauge user interest for the new feature. New methods (as opposed to new translations for existing methods) generally need several 👍 before they are considered for inclusion.

@ST-DDT ST-DDT added c: feature Request for new feature p: 1-normal Nothing urgent m: science Something is referring to the science module s: waiting for user interest Waiting for more users interested in this feature labels Sep 23, 2023
@ST-DDT ST-DDT added this to the vFuture milestone Sep 23, 2023
@CoolPlayLin
Copy link
Contributor Author

Why it fails?

@matthewmayer
Copy link
Contributor

Why it fails?

you need to add a JSDoc to the new method, with at least @example and @since tags

@CoolPlayLin
Copy link
Contributor Author

@matthewmayer What should I write since?

@matthewmayer
Copy link
Contributor

@matthewmayer What should I write since?

doesn't really matter. any future version e.g. 8.2.0 or 9.0.0. If the issue gets upvoted enough to be approved the PR would be adjusted later to match the correct release version.

@CoolPlayLin
Copy link
Contributor Author

done

@codecov
Copy link

codecov bot commented Sep 23, 2023

Codecov Report

Attention: Patch coverage is 92.85714% with 6 lines in your changes missing coverage. Please review.

Project coverage is 99.57%. Comparing base (871b2b0) to head (eda18b7).
Report is 405 commits behind head on next.

Files with missing lines Patch % Lines
src/definitions/science.ts 0.00% 5 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             next    #2415      +/-   ##
==========================================
- Coverage   99.57%   99.57%   -0.01%     
==========================================
  Files        2807     2808       +1     
  Lines      250452   250535      +83     
  Branches     1151     1151              
==========================================
+ Hits       249386   249465      +79     
- Misses       1038     1042       +4     
  Partials       28       28              
Files with missing lines Coverage Δ
src/locales/en/science/index.ts 100.00% <100.00%> (ø)
src/locales/en/science/notation.ts 100.00% <100.00%> (ø)
src/modules/science/index.ts 100.00% <100.00%> (ø)
src/definitions/science.ts 0.00% <0.00%> (ø)

... and 2 files with indirect coverage changes

@CoolPlayLin CoolPlayLin removed their assignment Sep 23, 2023
@ST-DDT ST-DDT added the needs rebase There is a merge conflict label Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: feature Request for new feature m: science Something is referring to the science module needs rebase There is a merge conflict p: 1-normal Nothing urgent s: waiting for user interest Waiting for more users interested in this feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add new notations module for science
3 participants