-
-
Notifications
You must be signed in to change notification settings - Fork 929
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(module): add new notations module for science #2415
base: next
Are you sure you want to change the base?
Conversation
CoolPlayLin
commented
Sep 23, 2023
•
edited
Loading
edited
- Resolve Add new notations module for science #2416
You should make a matching issue for this PR so that we can gauge user interest for the new feature. New methods (as opposed to new translations for existing methods) generally need several 👍 before they are considered for inclusion. |
Why it fails? |
you need to add a JSDoc to the new method, with at least |
@matthewmayer What should I write |
doesn't really matter. any future version e.g. 8.2.0 or 9.0.0. If the issue gets upvoted enough to be approved the PR would be adjusted later to match the correct release version. |
done |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## next #2415 +/- ##
==========================================
- Coverage 99.57% 99.57% -0.01%
==========================================
Files 2807 2808 +1
Lines 250452 250535 +83
Branches 1151 1151
==========================================
+ Hits 249386 249465 +79
- Misses 1038 1042 +4
Partials 28 28
|