Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

infra(unicorn): prefer-node-protocol #2420

Merged
merged 3 commits into from
Oct 7, 2023
Merged

infra(unicorn): prefer-node-protocol #2420

merged 3 commits into from
Oct 7, 2023

Conversation

Shinigami92
Copy link
Member

⚠️ #2418 needs to be merged first ⚠️

@Shinigami92 Shinigami92 added do NOT merge yet Do not merge this PR into the target branch yet c: infra Changes to our infrastructure or project setup labels Sep 23, 2023
@Shinigami92 Shinigami92 added this to the vAnytime milestone Sep 23, 2023
@Shinigami92 Shinigami92 requested a review from a team as a code owner September 23, 2023 21:42
@Shinigami92 Shinigami92 self-assigned this Sep 23, 2023
@codecov
Copy link

codecov bot commented Sep 23, 2023 •
edited
Loading

Codecov Report

Merging #2420 (0a3ca2f) into next (97b0c8b) will increase coverage by 0.00%.
The diff coverage is n/a.

Additional details and impacted files 
@@           Coverage Diff           @@
##             next    #2420   +/-   ##
=======================================
  Coverage   99.58%   99.59%           
=======================================
  Files        2823     2823           
  Lines      255523   255523           
  Branches     1102     1104    +2     
=======================================
+ Hits       254470   254476    +6     
+ Misses       1025     1019    -6     
  Partials       28       28

see 2 files with indirect coverage changes

ST-DDT
ST-DDT previously approved these changes Sep 23, 2023
View reviewed changes
@Shinigami92 Shinigami92 force-pushed the add-eslint-unicorn-dep branch from 4d917db to d204153 Compare September 23, 2023 23:33
@ST-DDT ST-DDT added the needs rebase There is a merge conflict label Sep 25, 2023
@xDivisionByZerox
Copy link
Member

I like this rule. Instead of waiting for #2418 we could activate this rule on its own (without all the recommended overhead).

@ST-DDT
Copy link
Member

ST-DDT commented Oct 2, 2023

Lets discuss how to enable the plugin tomorrow/in the next team meeting.

@ST-DDT ST-DDT added the s: needs decision Needs team/maintainer decision label Oct 2, 2023
Base automatically changed from add-eslint-unicorn-dep to next October 6, 2023 21:14
@xDivisionByZerox xDivisionByZerox dismissed ST-DDT’s stale review October 6, 2023 21:14

The base branch was changed.

@ST-DDT ST-DDT assigned ST-DDT and unassigned Shinigami92 Oct 6, 2023
@ST-DDT ST-DDT added p: 1-normal Nothing urgent and removed do NOT merge yet Do not merge this PR into the target branch yet s: needs decision Needs team/maintainer decision labels Oct 6, 2023
@ST-DDT ST-DDT removed the needs rebase There is a merge conflict label Oct 6, 2023
@ST-DDT ST-DDT requested review from a team October 6, 2023 23:40
@ST-DDT
Copy link
Member

ST-DDT commented Oct 6, 2023

Ready for review and merge.

@xDivisionByZerox xDivisionByZerox enabled auto-merge (squash) October 6, 2023 23:49
@xDivisionByZerox xDivisionByZerox merged commit 93bb134 into next Oct 7, 2023
21 checks passed
@ST-DDT ST-DDT deleted the unicorn/prefer-node-protocol branch October 7, 2023 00:02
@ST-DDT ST-DDT mentioned this pull request Oct 7, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xDivisionByZerox xDivisionByZerox xDivisionByZerox approved these changes

@ST-DDT ST-DDT ST-DDT approved these changes

@matthewmayer matthewmayer matthewmayer approved these changes

Assignees

@ST-DDT ST-DDT

Labels
c: infra Changes to our infrastructure or project setup p: 1-normal Nothing urgent
Projects
None yet
Milestone
vAnytime
Development

Successfully merging this pull request may close these issues.
4 participants
@Shinigami92 @xDivisionByZerox @ST-DDT @matthewmayer