Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: improve wording regarding locale selection #2436

Merged
merged 7 commits into from
Oct 9, 2023

Conversation

ST-DDT
Copy link
Member

@ST-DDT ST-DDT commented Oct 6, 2023

There is no locale to "set". You can only "pick" one. Not sure about the phrasing.

@ST-DDT ST-DDT added c: docs Improvements or additions to documentation p: 1-normal Nothing urgent labels Oct 6, 2023
@ST-DDT ST-DDT added this to the vAnytime milestone Oct 6, 2023
@ST-DDT ST-DDT requested review from a team October 6, 2023 19:58
@ST-DDT ST-DDT self-assigned this Oct 6, 2023
@codecov
Copy link

codecov bot commented Oct 6, 2023

Codecov Report

Merging #2436 (ab629bc) into next (fe3fb5d) will increase coverage by 0.00%.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##             next    #2436   +/-   ##
=======================================
  Coverage   99.58%   99.59%           
=======================================
  Files        2823     2823           
  Lines      255523   255523           
  Branches     1102     1109    +7     
=======================================
+ Hits       254466   254482   +16     
+ Misses       1029     1013   -16     
  Partials       28       28           

see 2 files with indirect coverage changes

README.md Outdated Show resolved Hide resolved
@ST-DDT ST-DDT requested review from matthewmayer and a team October 7, 2023 13:22
@ST-DDT ST-DDT requested a review from a team October 8, 2023 17:24
@ST-DDT ST-DDT enabled auto-merge (squash) October 9, 2023 12:06
@ST-DDT ST-DDT merged commit 762936c into next Oct 9, 2023
@ST-DDT ST-DDT deleted the docs/localization-wording branch October 9, 2023 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: docs Improvements or additions to documentation p: 1-normal Nothing urgent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants