-
-
Notifications
You must be signed in to change notification settings - Fork 919
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
infra(unicorn): no-hex-escape #2440
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Enforces a convention ]...[ for consistency and clarity.
Good think unicode encoding is so much more clear for me as a human than hex encoding xD
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't find either very readable. Could we define a constant for a non breaking space like
const nbsp = "\ua00"
a513bfa
Done |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## next #2440 +/- ##
==========================================
- Coverage 99.59% 99.59% -0.01%
==========================================
Files 2823 2823
Lines 255523 255525 +2
Branches 1106 1106
==========================================
- Hits 254487 254481 -6
- Misses 1008 1016 +8
Partials 28 28
|
Ref: #2439
Enables the
unicorn/no-hex-escape
lint rule.