Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

infra(unicorn): prefer-array-some #2451

Merged
merged 13 commits into from
Oct 26, 2023
Merged

infra(unicorn): prefer-array-some #2451

merged 13 commits into from
Oct 26, 2023

Conversation

ST-DDT
Copy link
Member

@ST-DDT ST-DDT commented Oct 9, 2023

@ST-DDT ST-DDT added p: 1-normal Nothing urgent c: infra Changes to our infrastructure or project setup labels Oct 9, 2023
@ST-DDT ST-DDT added this to the vAnytime milestone Oct 9, 2023
@ST-DDT ST-DDT requested review from a team October 9, 2023 09:54
@ST-DDT ST-DDT self-assigned this Oct 9, 2023
@ST-DDT ST-DDT mentioned this pull request Oct 9, 2023
Open
@codecov
Copy link

codecov bot commented Oct 9, 2023 •
edited
Loading

Codecov Report

Merging #2451 (91e76d6) into next (129c86f) will increase coverage by 0.00%.
Report is 1 commits behind head on next.
The diff coverage is n/a.

Additional details and impacted files 
@@           Coverage Diff           @@
##             next    #2451   +/-   ##
=======================================
  Coverage   99.59%   99.59%           
=======================================
  Files        2823     2823           
  Lines      255520   255520           
  Branches     1105     1109    +4     
=======================================
+ Hits       254477   254491   +14     
+ Misses       1015     1001   -14     
  Partials       28       28

see 1 file with indirect coverage changes

matthewmayer
matthewmayer requested changes Oct 9, 2023
View reviewed changes
test/modules/system.spec.ts Outdated Show resolved Hide resolved
@ST-DDT ST-DDT requested review from matthewmayer and a team October 9, 2023 19:05
import-brain
import-brain previously approved these changes Oct 20, 2023
View reviewed changes
@import-brain import-brain added the needs rebase There is a merge conflict label Oct 20, 2023
matthewmayer
matthewmayer previously approved these changes Oct 20, 2023
View reviewed changes
@ST-DDT ST-DDT removed the needs rebase There is a merge conflict label Oct 20, 2023
@ST-DDT ST-DDT requested review from import-brain and a team October 20, 2023 08:23
@ST-DDT ST-DDT added the s: accepted Accepted feature / Confirmed bug label Oct 20, 2023
@ST-DDT
Copy link
Member Author

ST-DDT commented Oct 20, 2023

Ready for review

@ST-DDT ST-DDT enabled auto-merge (squash) October 26, 2023 18:32
@ST-DDT ST-DDT merged commit 8a405fa into next Oct 26, 2023
38 checks passed
@ST-DDT ST-DDT deleted the infra/unicorn/prefer-array-some branch October 26, 2023 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xDivisionByZerox xDivisionByZerox xDivisionByZerox approved these changes

@matthewmayer matthewmayer Awaiting requested review from matthewmayer

@import-brain import-brain Awaiting requested review from import-brain

Assignees

@ST-DDT ST-DDT

Labels
c: infra Changes to our infrastructure or project setup p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug
Projects
None yet
Milestone
vAnytime
Development

Successfully merging this pull request may close these issues.
4 participants
@ST-DDT @matthewmayer @import-brain @xDivisionByZerox