Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

infra(unicorn): prefer-includes #2463

Merged
merged 3 commits into from
Oct 11, 2023
Merged

infra(unicorn): prefer-includes #2463

merged 3 commits into from
Oct 11, 2023

Conversation

ST-DDT
Copy link
Member

@ST-DDT ST-DDT commented Oct 10, 2023

@ST-DDT ST-DDT added p: 1-normal Nothing urgent c: infra Changes to our infrastructure or project setup labels Oct 10, 2023
@ST-DDT ST-DDT added this to the vAnytime milestone Oct 10, 2023
@ST-DDT ST-DDT requested review from a team October 10, 2023 09:00
@ST-DDT ST-DDT self-assigned this Oct 10, 2023
@ST-DDT ST-DDT mentioned this pull request Oct 10, 2023
Closed
@codecov
Copy link

codecov bot commented Oct 10, 2023 •
edited
Loading

Codecov Report

Merging #2463 (8d1a02c) into next (201d6e3) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files 
@@           Coverage Diff           @@
##             next    #2463   +/-   ##
=======================================
  Coverage   99.58%   99.59%           
=======================================
  Files        2823     2823           
  Lines      255518   255518           
  Branches     1104     1104           
=======================================
+ Hits       254459   254473   +14     
+ Misses       1031     1017   -14     
  Partials       28       28
Files Coverage Δ
src/modules/helpers/index.ts 98.98% <100.00%> (ø)
src/modules/helpers/unique.ts 98.70% <100.00%> (ø)

... and 1 file with indirect coverage changes

@ST-DDT ST-DDT mentioned this pull request Oct 10, 2023
Merged
@ST-DDT ST-DDT enabled auto-merge (squash) October 11, 2023 18:45
@ST-DDT ST-DDT merged commit 5395074 into next Oct 11, 2023
20 checks passed
@ST-DDT ST-DDT deleted the infra/unicorn/prefer-includes branch October 11, 2023 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xDivisionByZerox xDivisionByZerox xDivisionByZerox approved these changes

@matthewmayer matthewmayer matthewmayer approved these changes

Assignees

@ST-DDT ST-DDT

Labels
c: infra Changes to our infrastructure or project setup p: 1-normal Nothing urgent
Projects
None yet
Milestone
vAnytime
Development

Successfully merging this pull request may close these issues.
3 participants
@ST-DDT @matthewmayer @xDivisionByZerox