-
-
Notifications
You must be signed in to change notification settings - Fork 929
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
infra(unicorn): escape-case #2469
Conversation
I'm not sure about this rule, because our numbers use lowercase hex characters. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## next #2469 +/- ##
=======================================
Coverage 99.58% 99.58%
=======================================
Files 2823 2823
Lines 255517 255517
Branches 1101 1103 +2
=======================================
+ Hits 254463 254466 +3
+ Misses 1026 1023 -3
Partials 28 28
|
Maybe we should discuss if that is the expected behavior. There is propably a ISO or RFC that standardizes representation of those values. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see a problem with the rule as it only verifies static escaped characters. I see that there would be a mismatch between the values we use in our code base and the values we provide for users, but I would not consider this a different topic of discussion.
Ref: #2439
Enables the
unicorn/escape-case
lint rule.