-
-
Notifications
You must be signed in to change notification settings - Fork 919
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(algolia): use one search-index per branch #2513
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #2513 +/- ##
==========================================
- Coverage 99.57% 99.57% -0.01%
==========================================
Files 2807 2807
Lines 250379 250379
Branches 1143 1139 -4
==========================================
- Hits 249322 249307 -15
- Misses 1029 1044 +15
Partials 28 28 |
This looks straight forward to me 🤔 |
I kind of already did, but the index doesn't get populated, so we would loose the current search capabilities. |
That would not be a problem for me |
No, it won't. At least not for the last 5 months... |
We would also need to backport this PR to v6 to prevent potential conflicts with the newly created indexes. There souldn't be any, but better be safe I guess. |
we could talk about what you tested and how maybe later in a voice-call or team-meeting |
There is nothing to be confused about. |
do we maybe need to create an index there? with that button? the one fakerjs index that is there already has 6.13K records, so as far as I understand the index dynamically builds up, based on what people are searching on the docs |
Yes, you might have to create a new index, but even then it stays empty after the website build/time. |
The crawler is hosted and run on https://crawler.algolia.com/. We checked the configuration and noticed that we have to add the other subdomains to the whitelist. Thanks @Shinigami92 for the help debugging this. |
This now works as expected:
Ref:
|
Tries to fix: #2267
I couldn't find a way to actually test the changes.