fix(number): improve float generation for precisions of form 10^-n #2581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #2581 +/- ##
==========================================
- Coverage 99.57% 99.56% -0.01%
==========================================
Files 2807 2807
Lines 250374 250379 +5
Branches 1141 1137 -4
==========================================
- Hits 249314 249301 -13
- Misses 1032 1050 +18
Partials 28 28
|
matthewmayer
changed the title
matthewmayer
changed the title
|
Note this obviously conflicts with #2564, probably easiest to merge that first since it touches more code |
ST-DDT
reviewed
Dec 17, 2023
|
And thanks for tackling this ❤️ |
ST-DDT
reviewed
Dec 18, 2023
ST-DDT
reviewed
Dec 19, 2023
ST-DDT
reviewed
Dec 20, 2023
ST-DDT
added
c: bug
ST-DDT
approved these changes
Dec 20, 2023
|
Thanks for addressing all my comments 👍 |
ST-DDT
changed the title
This was referenced Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #2567
Changes the way that the 1/precision is calculated in faker.number.float() using Math.log10 and Math.pow
This ensures that if precision is 0.00001, you get exactly 100000 for example, not 99999.99999999999