-
-
Notifications
You must be signed in to change notification settings - Fork 932
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(number): add multipleOf to faker.number.int #2586
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #2586 +/- ##
==========================================
- Coverage 99.57% 99.57% -0.01%
==========================================
Files 3034 3034
Lines 250434 250453 +19
Branches 627 986 +359
==========================================
+ Hits 249375 249380 +5
- Misses 1030 1073 +43
+ Partials 29 0 -29
|
Co-authored-by: ST-DDT <ST-DDT@gmx.de>
Co-authored-by: ST-DDT <ST-DDT@gmx.de>
@matthewmayer What is the status on this PR? Can we help you? |
Yes, I think I need some help implementing your suggestions |
@matthewmayer Does the change look good to you? Ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lets just assume nobody is checking for the explicit error message in a catch block 😏
i think we can assume thats brittle enough to not be considered breaking |
looks good for me. i can't approve as its my own PR |
fix #2584