Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(typescript-eslint): no-useless-template-literals #2589

Merged

Conversation

ST-DDT
Copy link
Member

@ST-DDT ST-DDT commented Dec 27, 2023

Fixes the lint issues that would be reported after merging #2588

@ST-DDT ST-DDT added c: chore PR that doesn't affect the runtime behavior p: 1-normal Nothing urgent labels Dec 27, 2023
@ST-DDT ST-DDT added this to the vAnytime milestone Dec 27, 2023
@ST-DDT ST-DDT requested review from a team December 27, 2023 19:14
@ST-DDT ST-DDT self-assigned this Dec 27, 2023
Copy link

codecov bot commented Dec 27, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (293f127) 99.57% compared to head (6ad2d4b) 99.57%.
Report is 1 commits behind head on next.

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #2589      +/-   ##
==========================================
- Coverage   99.57%   99.57%   -0.01%     
==========================================
  Files        2807     2807              
  Lines      250379   250379              
  Branches     1144     1139       -5     
==========================================
- Hits       249323   249305      -18     
- Misses       1028     1046      +18     
  Partials       28       28              
Files Coverage Δ
src/modules/commerce/index.ts 98.85% <100.00%> (ø)
src/modules/lorem/index.ts 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

@xDivisionByZerox xDivisionByZerox enabled auto-merge (squash) December 28, 2023 14:24
@xDivisionByZerox xDivisionByZerox merged commit 1fc1bcc into next Dec 28, 2023
18 checks passed
@xDivisionByZerox xDivisionByZerox deleted the infra/typescript-eslint/no-useless-template-literals branch December 28, 2023 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: chore PR that doesn't affect the runtime behavior p: 1-normal Nothing urgent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants