Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(internet): deprecated redundant avatar method #2601

Merged
merged 3 commits into from
Jan 18, 2024
Merged

refactor(internet): deprecated redundant avatar method #2601

merged 3 commits into from
Jan 18, 2024

Conversation

ST-DDT
Copy link
Member

@ST-DDT ST-DDT commented Jan 14, 2024

@ST-DDT ST-DDT added p: 1-normal Nothing urgent c: refactor PR that affects the runtime behavior, but doesn't add new features or fixes bugs m: internet Something is referring to the internet module deprecation A deprecation was made in the PR labels Jan 14, 2024
@ST-DDT ST-DDT added this to the v8.x milestone Jan 14, 2024
@ST-DDT ST-DDT requested review from a team January 14, 2024 12:50
@ST-DDT ST-DDT self-assigned this Jan 14, 2024
ST-DDT
ST-DDT commented Jan 14, 2024
View reviewed changes
src/modules/internet/index.ts Outdated Show resolved Hide resolved
@codecov Codecov
Copy link

codecov bot commented Jan 14, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (872c855) 99.57% compared to head (67a00fd) 99.57%.

Additional details and impacted files 
@@           Coverage Diff           @@
##             next    #2601   +/-   ##
=======================================
  Coverage   99.57%   99.57%           
=======================================
  Files        2807     2807           
  Lines      250401   250411   +10     
  Branches     1141     1143    +2     
=======================================
+ Hits       249337   249347   +10     
  Misses       1036     1036           
  Partials       28       28
Files Coverage Δ
src/modules/internet/index.ts 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

@ST-DDT ST-DDT enabled auto-merge (squash) January 15, 2024 08:05
xDivisionByZerox
xDivisionByZerox approved these changes Jan 18, 2024
View reviewed changes
Copy link
Member

@xDivisionByZerox xDivisionByZerox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we deprecated this method now, we can't decide on replacing the implementation in the v9, as you comment suggests.

@ST-DDT ST-DDT merged commit d71bc47 into next Jan 18, 2024
20 checks passed
@ST-DDT ST-DDT deleted the refactor/internet/avatar/deprecate branch January 18, 2024 09:56
@dagistan-tuncbilek dagistan-tuncbilek mentioned this pull request Jun 14, 2024
Open
This was referenced Sep 13, 2024
Open
Open
Merged
@sindhuhack sindhuhack mentioned this pull request Sep 24, 2024
Open
@jiisuominen jiisuominen mentioned this pull request Nov 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xDivisionByZerox xDivisionByZerox xDivisionByZerox approved these changes

@import-brain import-brain import-brain approved these changes

@Shinigami92 Shinigami92 Shinigami92 approved these changes

@matthewmayer matthewmayer matthewmayer approved these changes

Assignees

@ST-DDT ST-DDT

Labels
c: refactor PR that affects the runtime behavior, but doesn't add new features or fixes bugs deprecation A deprecation was made in the PR m: internet Something is referring to the internet module p: 1-normal Nothing urgent
Projects
None yet
Milestone
v8.x
Development

Successfully merging this pull request may close these issues.

Deprecate or replace internet.avatar in favor of image.avatar
5 participants
@ST-DDT @matthewmayer @Shinigami92 @import-brain @xDivisionByZerox