Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

infra: use vitest config #2612

Merged
merged 3 commits into from
Jan 24, 2024
Merged

infra: use vitest config #2612

merged 3 commits into from
Jan 24, 2024

Conversation

Shinigami92
Copy link
Member

@Shinigami92 Shinigami92 commented Jan 20, 2024

this is just a minimal change to the vitest config
instead of using a vite config with /// <reference types="vitest" /> we use a vitest.config directly

because we do not use vite to bundle our project, but esbuild (or tsup in the future) there is no need to have a vite.config

https://vitest.dev/config/#configuration

@Shinigami92 Shinigami92 added the c: infra Changes to our infrastructure or project setup label Jan 20, 2024
@Shinigami92 Shinigami92 added this to the vAnytime milestone Jan 20, 2024
@Shinigami92 Shinigami92 self-assigned this Jan 20, 2024
@Shinigami92 Shinigami92 requested a review from a team as a code owner January 20, 2024 11:20
Copy link

codecov bot commented Jan 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ca50f82) 99.57% compared to head (faca2c8) 99.57%.

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #2612      +/-   ##
==========================================
- Coverage   99.57%   99.57%   -0.01%     
==========================================
  Files        2807     2807              
  Lines      250452   250452              
  Branches     1152     1148       -4     
==========================================
- Hits       249392   249379      -13     
- Misses       1032     1045      +13     
  Partials       28       28              

see 1 file with indirect coverage changes

@ST-DDT ST-DDT added the p: 1-normal Nothing urgent label Jan 20, 2024
@Shinigami92 Shinigami92 requested a review from a team January 22, 2024 10:21
@Shinigami92 Shinigami92 merged commit 7fce907 into next Jan 24, 2024
20 checks passed
@Shinigami92 Shinigami92 deleted the infra-use-vitest-config branch January 24, 2024 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: infra Changes to our infrastructure or project setup p: 1-normal Nothing urgent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants