Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: restore support for moduleResolution Node* #2749

Merged
merged 2 commits into from
Mar 15, 2024
Merged

Conversation

ST-DDT
Copy link
Member

@ST-DDT ST-DDT commented Mar 14, 2024

Can be tested with this line (currently throwing a built error):

Alternatively: We have to force our users to use moduleResolution: "Bundler"

@ST-DDT ST-DDT added c: bug Something isn't working p: 1-normal Nothing urgent labels Mar 14, 2024
@ST-DDT ST-DDT added this to the v9.0 milestone Mar 14, 2024
@ST-DDT ST-DDT requested review from a team March 14, 2024 18:21
@ST-DDT ST-DDT self-assigned this Mar 14, 2024
Copy link

codecov bot commented Mar 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.56%. Comparing base (2a50c76) to head (6f0f2fd).

Additional details and impacted files
@@           Coverage Diff            @@
##             next    #2749    +/-   ##
========================================
  Coverage   99.55%   99.56%            
========================================
  Files        2979     2979            
  Lines      250229   250229            
  Branches      976      630   -346     
========================================
+ Hits       249126   249146    +20     
+ Misses       1103     1083    -20     

see 2 files with indirect coverage changes

@ST-DDT ST-DDT enabled auto-merge (squash) March 15, 2024 16:25
Copy link

netlify bot commented Mar 15, 2024

Deploy Preview for vigilant-wescoff-04e480 ready!

Name Link
🔨 Latest commit 6f0f2fd
🔍 Latest deploy log https://app.netlify.com/sites/vigilant-wescoff-04e480/deploys/65f4778b82531a000862aff2
😎 Deploy Preview https://deploy-preview-2749--vigilant-wescoff-04e480.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ST-DDT ST-DDT merged commit 2f07483 into next Mar 15, 2024
20 checks passed
@ST-DDT ST-DDT deleted the fix/moduleResolution/Node branch March 15, 2024 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: bug Something isn't working p: 1-normal Nothing urgent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants