Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(locale): normalize vehicle data #2874

Merged
merged 3 commits into from
May 8, 2024

Conversation

xDivisionByZerox
Copy link
Member

Description

Follow-on to #2265.

Normalize the entries in the vehicle module definitions in all locales.

I choose this module because none of the datasets surpass the 1k entry limit, meaning that all modifications to locale files involve sorting entries only.

@xDivisionByZerox xDivisionByZerox added p: 1-normal Nothing urgent c: refactor PR that affects the runtime behavior, but doesn't add new features or fixes bugs c: locale Permutes locale definitions m: vehicle Something is referring to the vehicle module labels May 5, 2024
@xDivisionByZerox xDivisionByZerox added this to the vAnytime milestone May 5, 2024
@xDivisionByZerox xDivisionByZerox self-assigned this May 5, 2024
@xDivisionByZerox xDivisionByZerox requested a review from a team as a code owner May 5, 2024 09:25
Copy link

netlify bot commented May 5, 2024

Deploy Preview for fakerjs ready!

Name Link
🔨 Latest commit e702dcf
🔍 Latest deploy log https://app.netlify.com/sites/fakerjs/deploys/663b5d44096be800082a32c6
😎 Deploy Preview https://deploy-preview-2874.fakerjs.dev
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented May 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.95%. Comparing base (6e6fa4c) to head (e702dcf).

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #2874      +/-   ##
==========================================
- Coverage   99.95%   99.95%   -0.01%     
==========================================
  Files        2977     2977              
  Lines      215466   215466              
  Branches      597      946     +349     
==========================================
- Hits       215372   215365       -7     
- Misses         94      101       +7     
Files Coverage Δ
src/locales/ar/vehicle/fuel.ts 100.00% <100.00%> (ø)
src/locales/ar/vehicle/manufacturer.ts 100.00% <100.00%> (ø)
src/locales/ar/vehicle/model.ts 100.00% <100.00%> (ø)
src/locales/ar/vehicle/type.ts 100.00% <100.00%> (ø)
src/locales/en/vehicle/manufacturer.ts 100.00% <100.00%> (ø)
src/locales/en/vehicle/model.ts 100.00% <100.00%> (ø)
src/locales/fa/vehicle/fuel.ts 100.00% <100.00%> (ø)
src/locales/fa/vehicle/manufacturer.ts 100.00% <100.00%> (ø)
src/locales/fa/vehicle/model.ts 100.00% <100.00%> (ø)
src/locales/fa/vehicle/type.ts 100.00% <100.00%> (ø)
... and 11 more

... and 1 file with indirect coverage changes

@ST-DDT ST-DDT requested review from a team May 5, 2024 09:35
@xDivisionByZerox xDivisionByZerox enabled auto-merge (squash) May 8, 2024 11:09
@xDivisionByZerox xDivisionByZerox merged commit 737de3a into next May 8, 2024
20 checks passed
@ST-DDT ST-DDT deleted the refactor/locale/normalize-vehicle-data branch May 8, 2024 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: locale Permutes locale definitions c: refactor PR that affects the runtime behavior, but doesn't add new features or fixes bugs m: vehicle Something is referring to the vehicle module p: 1-normal Nothing urgent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants