-
-
Notifications
You must be signed in to change notification settings - Fork 943
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: delete CHANGELOG_old.md #2914
Conversation
✅ Deploy Preview for fakerjs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
I also considered trimming the "current" CHANGELOG.md (in a separate PR), to v8+ or v9+ with a link at the end to previous major versions. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #2914 +/- ##
==========================================
- Coverage 99.96% 99.95% -0.01%
==========================================
Files 2977 2977
Lines 215421 215422 +1
Branches 952 602 -350
==========================================
- Hits 215349 215335 -14
- Misses 72 87 +15 |
I'd prefer not to do this. I find myself looking into changelog files of other libraries. It's quite frustrating when you want to do a fuzzy search for when a specific thing was changed in the changelog file, but you only have the latest version in there. Also, what would we gain by trimming the changelogs content to the current version? First thing that came to mind for me was better load time when viewing the file online. That should be neglectably low, right? Edit: |
Why not leave a link to the final revision of changelog_old at the bottom of changelog together with an explanatory note. If I want to understand the history of a project i look at its changelog, so that would better clarify that the project didn't start at v6. |
There is a short text linking to the old one:
Do you want to us to explain the reason why it is cut there?
|
Deletes the
CHANGELOG_old.md
which contains the changelog prior to v6.IMO at this point this file is hardly relevant anymore and can be deleted.