-
-
Notifications
You must be signed in to change notification settings - Fork 919
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(internet): add jwt method #2936
Conversation
✅ Deploy Preview for fakerjs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for contributing.
Could you please also comment in the linked issue so we can assign it to you so it easier to see that the issue is being worked on?
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## next #2936 +/- ##
==========================================
- Coverage 99.96% 99.95% -0.01%
==========================================
Files 2796 2797 +1
Lines 216704 216762 +58
Branches 953 578 -375
==========================================
+ Hits 216628 216672 +44
- Misses 76 90 +14
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than the following minor issues and the Buffer
issue above, this looks good to me.
is this up for review? or should I wait a bit? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work so far 👍
Discussion point has been removed for being off topic @eLoyyyyy the test snapshots as well as some formatting needs to be updated. You can run |
This comment was marked as off-topic.
This comment was marked as off-topic.
Updated the test snapshots. My bad for not running preflight before pushing code. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks really good. I have questions/suggestions for one last time.
This comment was marked as off-topic.
This comment was marked as off-topic.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution. ❤️
d311ab2
to
52e02f7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few minor tweaks and then this is good to go.
@xDivisionByZerox Could you please review this PR (or dismiss your previous one)? |
Thank you for you contribution. ❤️ This feature will be available in the upcoming v9.1 release of faker. |
Closes #1282