docs(guide): add locale error handling sections #3055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ST-DDT
added
c: docs
✅ Deploy Preview for fakerjs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
10 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #3055 +/- ##
==========================================
- Coverage 99.97% 99.96% -0.01%
==========================================
Files 2772 2772
Lines 226173 226173
Branches 592 941 +349
==========================================
- Hits 226108 226105 -3
- Misses 65 68 +3 |
|
Could we add an example of a case where a built in locale definition is deliberately null? For example location.zipCode for en_HK because Hong Kong has no ZIP codes. |
Shinigami92
reviewed
Aug 13, 2024
|
|
|
@ST-DDT 2 |
|
Ready for review |
Shinigami92
previously approved these changes
Aug 13, 2024
Co-authored-by: DivisionByZero <leyla.jaehnig@gmx.de>
xDivisionByZerox
approved these changes
Aug 14, 2024
Shinigami92
approved these changes
Aug 14, 2024
ejcheng
approved these changes
Aug 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #3053
nullLocale Data #3053This PR adds an explanation to the missing and non-applicable locale errors and ways to handle them.
Preview: