-
-
Notifications
You must be signed in to change notification settings - Fork 944
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: blog post v9.0 #3056
docs: blog post v9.0 #3056
Conversation
✅ Deploy Preview for fakerjs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
You need to add a link here faker/docs/.vitepress/config.ts Lines 62 to 65 in 0fd0402
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice WIP. Thanks for preparing all this.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #3056 +/- ##
==========================================
- Coverage 99.96% 99.96% -0.01%
==========================================
Files 2804 2804
Lines 216974 216974
Branches 582 956 +374
==========================================
- Hits 216903 216892 -11
- Misses 71 82 +11 |
Anything else missing for this? |
(We should probably rename the file to match the current date, but otherwise I think it is good to go) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm personally not a fan of the \
and also I prefer '
over ’
, but 🤷 no blocking from my side here
I agree with the file rename, then we are potentially good to go
Fixed |
we should rename the file before merging, because once it is merged and public, it could be referenced by blogs like dev.to or medium |
I think we should merge this and then start the release process for v9.1. |
Description
This PR adds a blog post page to the documentation. The page focuses on technical details that were interesting during the development of v9.
Preview: