Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: blog post v9.0 #3056

Merged
merged 19 commits into from
Oct 26, 2024
Merged

docs: blog post v9.0 #3056

merged 19 commits into from
Oct 26, 2024

Conversation

xDivisionByZerox
Copy link
Member

@xDivisionByZerox xDivisionByZerox commented Aug 15, 2024

Description

This PR adds a blog post page to the documentation. The page focuses on technical details that were interesting during the development of v9.

Preview:

Copy link

netlify bot commented Aug 15, 2024

Deploy Preview for fakerjs ready!

Name Link
🔨 Latest commit b437755
🔍 Latest deploy log https://app.netlify.com/sites/fakerjs/deploys/671ced0fd09a600008a8579f
😎 Deploy Preview https://deploy-preview-3056.fakerjs.dev
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@xDivisionByZerox xDivisionByZerox added c: docs Improvements or additions to documentation p: 1-normal Nothing urgent labels Aug 15, 2024
@xDivisionByZerox xDivisionByZerox added this to the v9.0 milestone Aug 15, 2024
@Shinigami92
Copy link
Member

You need to add a link here

items: [
{ text: '2022-09-08', link: '/about/announcements/2022-09-08' },
{ text: '2022-01-14', link: '/about/announcements/2022-01-14' },
],

Copy link
Member

@ST-DDT ST-DDT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice WIP. Thanks for preparing all this.

docs/about/announcements/2024-08-31-whats-new-in-9-0.md Outdated Show resolved Hide resolved
docs/guide/upgrading.md Show resolved Hide resolved
docs/guide/upgrading.md Show resolved Hide resolved
docs/about/announcements/2024-08-31-whats-new-in-9-0.md Outdated Show resolved Hide resolved
docs/about/announcements/2024-08-31-whats-new-in-9-0.md Outdated Show resolved Hide resolved
docs/about/announcements/2024-08-31-whats-new-in-9-0.md Outdated Show resolved Hide resolved
docs/about/announcements/2024-08-31-whats-new-in-9-0.md Outdated Show resolved Hide resolved
docs/about/announcements/2024-08-31-whats-new-in-9-0.md Outdated Show resolved Hide resolved
docs/about/announcements/2024-08-31-whats-new-in-9-0.md Outdated Show resolved Hide resolved
@Shinigami92 Shinigami92 mentioned this pull request Sep 4, 2024
23 tasks
Copy link

codecov bot commented Oct 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.96%. Comparing base (af1dbcd) to head (b437755).
Report is 1 commits behind head on next.

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #3056      +/-   ##
==========================================
- Coverage   99.96%   99.96%   -0.01%     
==========================================
  Files        2804     2804              
  Lines      216974   216974              
  Branches      582      956     +374     
==========================================
- Hits       216903   216892      -11     
- Misses         71       82      +11     

see 1 file with indirect coverage changes

@ST-DDT
Copy link
Member

ST-DDT commented Oct 17, 2024

Anything else missing for this?

ST-DDT
ST-DDT previously approved these changes Oct 17, 2024
@ST-DDT ST-DDT requested review from matthewmayer, Shinigami92 and a team October 17, 2024 11:09
ST-DDT
ST-DDT previously approved these changes Oct 17, 2024
@ST-DDT ST-DDT requested a review from a team October 17, 2024 11:12
@ST-DDT
Copy link
Member

ST-DDT commented Oct 17, 2024

(We should probably rename the file to match the current date, but otherwise I think it is good to go)

Copy link
Member

@Shinigami92 Shinigami92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm personally not a fan of the \ and also I prefer ' over , but 🤷 no blocking from my side here

I agree with the file rename, then we are potentially good to go

@ST-DDT
Copy link
Member

ST-DDT commented Oct 17, 2024

also I prefer ' over

Fixed

ST-DDT
ST-DDT previously approved these changes Oct 17, 2024
@Shinigami92
Copy link
Member

we should rename the file before merging, because once it is merged and public, it could be referenced by blogs like dev.to or medium

@ST-DDT
Copy link
Member

ST-DDT commented Oct 18, 2024

I think we should merge this and then start the release process for v9.1.

@xDivisionByZerox xDivisionByZerox marked this pull request as ready for review October 25, 2024 19:52
@ST-DDT ST-DDT enabled auto-merge (squash) October 26, 2024 13:24
@ST-DDT ST-DDT merged commit 8bceb58 into next Oct 26, 2024
27 checks passed
@ST-DDT ST-DDT deleted the docs/blog-post-v9.0 branch October 26, 2024 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: docs Improvements or additions to documentation p: 1-normal Nothing urgent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants