Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(date): add hints how to generate date ranges #3128

Merged
merged 8 commits into from
Oct 20, 2024
Merged

Conversation

ST-DDT
Copy link
Member

@ST-DDT ST-DDT commented Sep 22, 2024

Picks up a suggestion from #3107 and explains how date ranges can be generated easily.

Preview: https://deploy-preview-3128.fakerjs.dev/api/date.html#overview

grafik

Not sure, about the phrasing and location of the text.

@ST-DDT ST-DDT added c: docs Improvements or additions to documentation p: 1-normal Nothing urgent m: date Something is referring to the date module labels Sep 22, 2024
@ST-DDT ST-DDT added this to the vAnytime milestone Sep 22, 2024
@ST-DDT ST-DDT requested review from a team September 22, 2024 08:54
@ST-DDT ST-DDT self-assigned this Sep 22, 2024
Copy link

netlify bot commented Sep 22, 2024

Deploy Preview for fakerjs ready!

Name Link
🔨 Latest commit 4097028
🔍 Latest deploy log https://app.netlify.com/sites/fakerjs/deploys/671526ae7e39fd0009e59851
😎 Deploy Preview https://deploy-preview-3128.fakerjs.dev
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Sep 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.96%. Comparing base (abd4d24) to head (4097028).
Report is 1 commits behind head on next.

Additional details and impacted files
@@           Coverage Diff           @@
##             next    #3128   +/-   ##
=======================================
  Coverage   99.96%   99.96%           
=======================================
  Files        2798     2798           
  Lines      227335   227335           
  Branches      953      954    +1     
=======================================
+ Hits       227246   227262   +16     
+ Misses         89       73   -16     
Files with missing lines Coverage Δ
src/modules/date/index.ts 100.00% <ø> (ø)

... and 1 file with indirect coverage changes

@ST-DDT ST-DDT added the s: needs decision Needs team/maintainer decision label Sep 23, 2024
@ST-DDT ST-DDT removed the s: needs decision Needs team/maintainer decision label Oct 10, 2024
@ST-DDT ST-DDT requested review from xDivisionByZerox and a team October 10, 2024 22:12
@ST-DDT ST-DDT enabled auto-merge (squash) October 20, 2024 15:50
@ST-DDT ST-DDT merged commit 3f3d628 into next Oct 20, 2024
23 checks passed
@ST-DDT ST-DDT deleted the docs/date/date-ranges branch October 20, 2024 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: docs Improvements or additions to documentation m: date Something is referring to the date module p: 1-normal Nothing urgent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants