-
-
Notifications
You must be signed in to change notification settings - Fork 931
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(guide): remove esModuleInterop flag from config #3192
Conversation
✅ Deploy Preview for fakerjs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #3192 +/- ##
==========================================
- Coverage 99.96% 99.95% -0.01%
==========================================
Files 2805 2805
Lines 217115 217115
Branches 973 970 -3
==========================================
- Hits 217036 217020 -16
- Misses 79 95 +16 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Due to us using named exports I don't see who this flag would be required for our users.
For reference: https://www.typescriptlang.org/tsconfig/#esModuleInterop |
AFAICT our users don't need the
esModuleInterop
(at least for our code).So we should remove them from our guide and I also removed them from our playground.
Could you please verify that there aren't any cases that I missed where our users need it?