Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(guide): remove esModuleInterop flag from config #3192

Merged
merged 6 commits into from
Nov 9, 2024

Conversation

ST-DDT
Copy link
Member

@ST-DDT ST-DDT commented Oct 18, 2024

AFAICT our users don't need the esModuleInterop (at least for our code).
So we should remove them from our guide and I also removed them from our playground.

Could you please verify that there aren't any cases that I missed where our users need it?

@ST-DDT ST-DDT added c: docs Improvements or additions to documentation p: 1-normal Nothing urgent labels Oct 18, 2024
@ST-DDT ST-DDT added this to the vAnytime milestone Oct 18, 2024
@ST-DDT ST-DDT requested review from a team October 18, 2024 14:28
@ST-DDT ST-DDT self-assigned this Oct 18, 2024
Copy link

netlify bot commented Oct 18, 2024

Deploy Preview for fakerjs ready!

Name Link
🔨 Latest commit 26ca188
🔍 Latest deploy log https://app.netlify.com/sites/fakerjs/deploys/672f3632f227910008b707c7
😎 Deploy Preview https://deploy-preview-3192.fakerjs.dev
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Oct 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.95%. Comparing base (519d212) to head (26ca188).
Report is 1 commits behind head on next.

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #3192      +/-   ##
==========================================
- Coverage   99.96%   99.95%   -0.01%     
==========================================
  Files        2805     2805              
  Lines      217115   217115              
  Branches      973      970       -3     
==========================================
- Hits       217036   217020      -16     
- Misses         79       95      +16     

see 2 files with indirect coverage changes

Copy link
Member

@xDivisionByZerox xDivisionByZerox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Due to us using named exports I don't see who this flag would be required for our users.

@xDivisionByZerox
Copy link
Member

@ST-DDT ST-DDT enabled auto-merge (squash) November 9, 2024 10:15
@ST-DDT ST-DDT merged commit d0f9f67 into next Nov 9, 2024
23 checks passed
@ST-DDT ST-DDT deleted the docs/usage/esModuleInterop branch November 9, 2024 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: docs Improvements or additions to documentation p: 1-normal Nothing urgent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants