Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix vite import warning #3248

Merged
merged 2 commits into from
Nov 9, 2024
Merged

test: fix vite import warning #3248

merged 2 commits into from
Nov 9, 2024

Conversation

ST-DDT
Copy link
Member

@ST-DDT ST-DDT commented Nov 4, 2024

Fixes the following warning during test:

15:24:06 [vite] warning: invalid import "../dist/locale/${locale}". A file extension must be included in the static part of the import. For example: import(./foo/${bar}.js).
Plugin: vite:dynamic-import-vars
File: ~/faker/test/locale-imports.spec.ts

The warning can be triggered using the following command when this PR is not applied:

pnpm run test test/locale-imports.spec.ts

@ST-DDT ST-DDT added p: 1-normal Nothing urgent c: test labels Nov 4, 2024
@ST-DDT ST-DDT added this to the vAnytime milestone Nov 4, 2024
@ST-DDT ST-DDT requested review from a team November 4, 2024 14:29
@ST-DDT ST-DDT self-assigned this Nov 4, 2024
Copy link

netlify bot commented Nov 4, 2024

Deploy Preview for fakerjs ready!

Name Link
🔨 Latest commit a1ea4de
🔍 Latest deploy log https://app.netlify.com/sites/fakerjs/deploys/672f37150a038c0008410d7e
😎 Deploy Preview https://deploy-preview-3248.fakerjs.dev
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Nov 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.95%. Comparing base (d0f9f67) to head (a1ea4de).
Report is 1 commits behind head on next.

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #3248      +/-   ##
==========================================
- Coverage   99.96%   99.95%   -0.01%     
==========================================
  Files        2805     2805              
  Lines      217115   217115              
  Branches      975      970       -5     
==========================================
- Hits       217034   217022      -12     
- Misses         81       93      +12     

see 1 file with indirect coverage changes

@ST-DDT ST-DDT enabled auto-merge (squash) November 9, 2024 10:16
@ST-DDT ST-DDT merged commit 5832417 into next Nov 9, 2024
23 checks passed
@ST-DDT ST-DDT deleted the fix/vitest/vite-warning branch November 9, 2024 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants