Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(internet): ensure domainWord always returns a valid value in all locales #3253

Merged
merged 1 commit into from
Nov 8, 2024

Conversation

matthewmayer
Copy link
Contributor

@matthewmayer matthewmayer commented Nov 7, 2024

fix #3251

If faker.word.noun()/adjective() doesnt return useful output, fall back to faker.lorem.word() or a random string

Fixes issues in fa,ko,zh-CN

af_ZA silent-couch
ar married-minister
az trained-thigh
base
cs_CZ thick-strategy
da larmende-myndighed
de ehrgeizig-verhutung
de_AT heimlich-kilometer
de_CH standhaft-ph-wert
dv tangible-reach
el small-trench
en tough-perfection
en_AU baggy-alert
en_AU_ocker rare-platypus
en_BORK dim-euphonium
en_CA authentic-viability
en_GB flowery-larva
en_GH ecstatic-characterization
en_HK cumbersome-desk
en_IE self-reliant-academics
en_IN deficient-doorpost
en_NG troubled-co-producer
en_US happy-taro
en_ZA tense-chasuble
eo insistent-sprinkles
es esteemed-catalyst
es_MX crushing-bookend
fa omhjh-vkzoy
fi feline-independence
fr sympathique-communaute-etudiante
fr_BE lache-hote
fr_CA rectangulaire-personnel
fr_CH timide-rectorat
fr_LU turquoise-commissionnaire
fr_SN dense-police
he stark-entry
hr golden-priesthood
hu narancssargas-szalagos-likacsosgomba
hy short-transom
id_ID tall-elevation
it grimy-pomelo
ja whopping-slime
ka_GE frightened-sarong
ko slek-adwpi
lv unhealthy-dream
mk natural-heroine
nb_NO apenbar-eyebrow
ne necessary-mixture
nl circular-space
nl_BE unknown-range
pl talkative-hyphenation
pt_BR bright-membership
pt_PT chilly-devil
ro bright-spirit
ro_MD flashy-obesity
ru parallel-feather
sk soft-fedora
sr_RS_latin unfinished-bog
sv vengeful-flight
th brilliant-cassava
tr foolish-widow
uk strong-expense
ur warm-distinction
uz_UZ_latin petty-label
vi delectable-kick
yo_NG both-pigsty
zh_CN venustas-reporter
zh_TW better-range
zu_ZA inexperienced-republican

@matthewmayer matthewmayer requested a review from a team as a code owner November 7, 2024 01:48
Copy link

netlify bot commented Nov 7, 2024

Deploy Preview for fakerjs ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 5337c8d
🔍 Latest deploy log https://app.netlify.com/sites/fakerjs/deploys/672c1c616b3ea100083e1948
😎 Deploy Preview https://deploy-preview-3253.fakerjs.dev
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Nov 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.96%. Comparing base (69173a3) to head (5337c8d).
Report is 1 commits behind head on next.

Additional details and impacted files
@@           Coverage Diff            @@
##             next    #3253    +/-   ##
========================================
  Coverage   99.95%   99.96%            
========================================
  Files        2805     2805            
  Lines      217098   217115    +17     
  Branches      586      974   +388     
========================================
+ Hits       217010   217035    +25     
+ Misses         88       80     -8     
Files with missing lines Coverage Δ
src/modules/internet/index.ts 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

@ST-DDT ST-DDT added this to the vAnytime milestone Nov 7, 2024
@ST-DDT ST-DDT added c: bug Something isn't working p: 1-normal Nothing urgent labels Nov 7, 2024
src/modules/internet/index.ts Show resolved Hide resolved
@ST-DDT ST-DDT requested review from a team November 7, 2024 08:51
@ST-DDT ST-DDT enabled auto-merge (squash) November 8, 2024 10:57
@ST-DDT ST-DDT merged commit 525fedc into faker-js:next Nov 8, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: bug Something isn't working p: 1-normal Nothing urgent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Korean faker giving invalid urls
4 participants