Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

infra(unicorn): consistent-function-scoping #3255

Merged
merged 3 commits into from
Nov 14, 2024

Conversation

ST-DDT
Copy link
Member

@ST-DDT ST-DDT commented Nov 10, 2024

Ref: #2439


Move inline functions without scope to the root of the file as standalone functions.

Related:

@ST-DDT ST-DDT added p: 1-normal Nothing urgent c: infra Changes to our infrastructure or project setup labels Nov 10, 2024
@ST-DDT ST-DDT added this to the vAnytime milestone Nov 10, 2024
@ST-DDT ST-DDT requested review from a team November 10, 2024 19:19
@ST-DDT ST-DDT self-assigned this Nov 10, 2024
Copy link

netlify bot commented Nov 10, 2024

Deploy Preview for fakerjs ready!

Name Link
🔨 Latest commit c73ff36
🔍 Latest deploy log https://app.netlify.com/sites/fakerjs/deploys/67366f9bcc456e000832b070
😎 Deploy Preview https://deploy-preview-3255.fakerjs.dev
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Nov 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.96%. Comparing base (9abaed1) to head (6187b28).

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #3255      +/-   ##
==========================================
- Coverage   99.96%   99.96%   -0.01%     
==========================================
  Files        2805     2805              
  Lines      217129   217139      +10     
  Branches      976      972       -4     
==========================================
+ Hits       217055   217058       +3     
- Misses         74       81       +7     
Files with missing lines Coverage Δ
src/modules/color/index.ts 100.00% <100.00%> (ø)
src/modules/food/index.ts 100.00% <100.00%> (ø)
src/modules/internet/index.ts 100.00% <100.00%> (ø)
src/modules/system/index.ts 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

@ST-DDT ST-DDT requested a review from a team November 11, 2024 08:54
@ST-DDT ST-DDT added this pull request to the merge queue Nov 14, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 14, 2024
@ST-DDT ST-DDT enabled auto-merge (squash) November 14, 2024 21:45
@ST-DDT ST-DDT merged commit 188309a into next Nov 14, 2024
21 checks passed
@ST-DDT ST-DDT deleted the infra/unicorn/consistent-function-scoping branch November 14, 2024 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: infra Changes to our infrastructure or project setup p: 1-normal Nothing urgent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants