refactor(helpers): introduce allowHuge flag #3256
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ST-DDT
added
p: 1-normal
✅ Deploy Preview for fakerjs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
10 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #3256 +/- ##
==========================================
- Coverage 99.96% 99.96% -0.01%
==========================================
Files 2805 2806 +1
Lines 217115 217130 +15
Branches 976 976
==========================================
+ Hits 217049 217051 +2
- Misses 66 79 +13
|
|
Should this maybe just be a warning rather than an error? |
For now, I opted for an error as there is a strong connection between the error and the call location. A warning just appears in the log and needs extra context for assiciating it with the source. If the others think, this should be a warning or should (not) be there at all. I would like to hear about it as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Second part of #2695
Adds a
allowHugeflag tofaker.helpers.multiple. If not set, the number of elements is limited to < 1 Mio.I considered lowering the limit to just 100k as even 1 Mio elements take quite the while to generate.
Once this PR is accepted I'll continue with the string and lorem(?) module.