Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

infra(CI): skip required CI steps in merge_queues #3265

Merged
merged 2 commits into from
Nov 21, 2024

Conversation

ST-DDT
Copy link
Member

@ST-DDT ST-DDT commented Nov 14, 2024

Another attempt at enabling the merge queue.

Previous attempt: #3245


Both the fail-by-blocking-label and Semantic Pull Request pipelines require the pull_request context.

There are two solutions to the problem:

  • Make these steps optional, which might lead to accidental merges of bad values
  • Let the CI skip the failing tasks in merge queues, but keep them otherwise required

I decided to try the later one first.

These solutions were suggested here:

I'm once again unable to test these changes myself.

@ST-DDT ST-DDT added p: 1-normal Nothing urgent c: infra Changes to our infrastructure or project setup labels Nov 14, 2024
@ST-DDT ST-DDT added this to the vAnytime milestone Nov 14, 2024
@ST-DDT ST-DDT requested review from a team November 14, 2024 22:00
@ST-DDT ST-DDT self-assigned this Nov 14, 2024
Copy link

netlify bot commented Nov 14, 2024

Deploy Preview for fakerjs ready!

Name Link
🔨 Latest commit 3709226
🔍 Latest deploy log https://app.netlify.com/sites/fakerjs/deploys/673c7f884ef41e0008984f2c
😎 Deploy Preview https://deploy-preview-3265.fakerjs.dev
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Nov 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.95%. Comparing base (b0a5ad3) to head (3709226).
Report is 1 commits behind head on next.

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #3265      +/-   ##
==========================================
- Coverage   99.96%   99.95%   -0.01%     
==========================================
  Files        2806     2806              
  Lines      217156   217156              
  Branches      976      970       -6     
==========================================
- Hits       217075   217061      -14     
- Misses         81       95      +14     

see 1 file with indirect coverage changes

---- 🚨 Try these New Features:

@ST-DDT ST-DDT requested a review from a team November 19, 2024 12:07
@ST-DDT ST-DDT merged commit 4436a77 into next Nov 21, 2024
23 checks passed
@ST-DDT ST-DDT deleted the infra/ci/merge_queue/ignore branch November 21, 2024 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: infra Changes to our infrastructure or project setup p: 1-normal Nothing urgent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants