Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(image): improve error text #3278

Merged
merged 1 commit into from
Nov 25, 2024
Merged

Conversation

ST-DDT
Copy link
Member

@ST-DDT ST-DDT commented Nov 25, 2024

Fixes/improves the error messages in the image integration test.

promise rejected "Error: Bad StatusCode 504 expected 200 for 'undefined'" instead of resolving

location contains the redirect target, so it isn't set for errors.
I also adjusted the no statusCode case to include the address similar to all the other cases.

@ST-DDT ST-DDT added p: 1-normal Nothing urgent c: test m: image Something is referring to the image module labels Nov 25, 2024
@ST-DDT ST-DDT added this to the vAnytime milestone Nov 25, 2024
@ST-DDT ST-DDT requested review from a team November 25, 2024 09:07
@ST-DDT ST-DDT self-assigned this Nov 25, 2024
Copy link

netlify bot commented Nov 25, 2024

Deploy Preview for fakerjs ready!

Name Link
🔨 Latest commit 2b32891
🔍 Latest deploy log https://app.netlify.com/sites/fakerjs/deploys/67443e4247475d00080c5485
😎 Deploy Preview https://deploy-preview-3278.fakerjs.dev
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Nov 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.96%. Comparing base (56acea3) to head (2b32891).
Report is 4 commits behind head on next.

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #3278      +/-   ##
==========================================
- Coverage   99.97%   99.96%   -0.01%     
==========================================
  Files        2806     2806              
  Lines      217156   217156              
  Branches      982      976       -6     
==========================================
- Hits       217092   217080      -12     
- Misses         64       76      +12     

see 1 file with indirect coverage changes

@ST-DDT ST-DDT added this pull request to the merge queue Nov 25, 2024
Merged via the queue into next with commit 361ece6 Nov 25, 2024
28 checks passed
@ST-DDT ST-DDT deleted the test/integration/image/fix-error-text branch November 25, 2024 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: test m: image Something is referring to the image module p: 1-normal Nothing urgent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants