fix: basic wildcard range handling + add more tests #3322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ST-DDT
added
c: bug
✅ Deploy Preview for fakerjs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #3322 +/- ##
=======================================
Coverage 99.96% 99.96%
=======================================
Files 2806 2806
Lines 217076 217087 +11
Branches 968 970 +2
=======================================
+ Hits 217003 217018 +15
+ Misses 73 69 -4
|
import-brain
changed the title
Shinigami92
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially fixes #3302
This PR tries to fix the wildcard pattern support. Now, quantified '.' and case insensitive patterns are working.
However, due to limitations of the current implementation, the same isn't possible for non-quantified characters ('.' vs '.{1}').
So the main focus of this PR is adding more tests.
I'm not sure if the partial fix improves things, or whether we should start with just the tests and rewrite the entire method later.
See the linked issue for more problems with the current implementation.