Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: rewrite time tests #421

Merged
merged 3 commits into from
Feb 10, 2022
Merged

test: rewrite time tests #421

merged 3 commits into from
Feb 10, 2022

Conversation

Shinigami92
Copy link
Member

These are only prepared tests for now, cause it's not seed based yet

@Shinigami92 Shinigami92 self-assigned this Feb 4, 2022
@Shinigami92 Shinigami92 requested a review from a team as a code owner February 4, 2022 18:38
@Shinigami92 Shinigami92 mentioned this pull request Feb 4, 2022
Closed
ST-DDT
ST-DDT reviewed Feb 4, 2022
View reviewed changes
Copy link
Member

@ST-DDT ST-DDT left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about the other methods? Such as future, past, ...

Ups. Wrong file.

@Shinigami92 Shinigami92 requested a review from a team February 4, 2022 20:05
ST-DDT
ST-DDT previously approved these changes Feb 4, 2022
View reviewed changes
@Shinigami92 Shinigami92 requested a review from a team February 4, 2022 20:51
@Shinigami92 Shinigami92 force-pushed the test-time-rewrite branch 2 times, most recently from 2b00137 to 22c16d8 Compare February 4, 2022 23:36
@codecov
Copy link

codecov bot commented Feb 4, 2022 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (main@14ecb26). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #421   +/-   ##
=======================================
  Coverage        ?   99.32%           
=======================================
  Files           ?     1920           
  Lines           ?   174272           
  Branches        ?      893           
=======================================
  Hits            ?   173100           
  Misses          ?     1116           
  Partials        ?       56

ST-DDT
ST-DDT previously approved these changes Feb 4, 2022
View reviewed changes
@ST-DDT ST-DDT requested a review from a team February 4, 2022 23:40
ST-DDT
ST-DDT previously approved these changes Feb 6, 2022
View reviewed changes
@ST-DDT ST-DDT requested a review from a team February 6, 2022 13:38
@ST-DDT ST-DDT requested a review from a team February 7, 2022 10:22
@Shinigami92 Shinigami92 merged commit bed7182 into main Feb 10, 2022
@Shinigami92 Shinigami92 deleted the test-time-rewrite branch February 10, 2022 19:27
demipel8 pushed a commit to demipel8/faker that referenced this pull request Mar 11, 2022
@Shinigami92 @demipel8
test: rewrite time tests (faker-js#421)
acec1fd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prisis prisis prisis approved these changes

@ST-DDT ST-DDT ST-DDT approved these changes

Assignees

@Shinigami92 Shinigami92

Labels
c: test
Projects
None yet
Milestone
v6.0 - Ensure Project Foundation
Development

Successfully merging this pull request may close these issues.
3 participants
@Shinigami92 @ST-DDT @prisis