Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: rewrite finance.spec.ts #433

Merged
merged 4 commits into from
Feb 5, 2022
Merged

Conversation

togami2864
Copy link
Contributor

ref #287
just rewrite finance.spec.ts

@togami2864 togami2864 requested a review from a team as a code owner February 5, 2022 13:41
@codecov
Copy link

codecov bot commented Feb 5, 2022

Codecov Report

Merging #433 (91df241) into main (832bf8a) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #433   +/-   ##
=======================================
  Coverage   94.24%   94.24%           
=======================================
  Files        1920     1920           
  Lines      173955   173955           
  Branches      108      108           
=======================================
  Hits       163942   163942           
  Misses       9905     9905           
  Partials      108      108           

ST-DDT
ST-DDT previously approved these changes Feb 5, 2022
Copy link
Member

@ST-DDT ST-DDT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@ST-DDT ST-DDT requested a review from a team February 5, 2022 13:50
@ST-DDT ST-DDT added the c: test label Feb 5, 2022
test/finance.spec.ts Outdated Show resolved Hide resolved
test/finance.spec.ts Outdated Show resolved Hide resolved
test/finance.spec.ts Outdated Show resolved Hide resolved
test/finance.spec.ts Outdated Show resolved Hide resolved
test/finance.spec.ts Outdated Show resolved Hide resolved
Shinigami92
Shinigami92 previously approved these changes Feb 5, 2022
test/finance.spec.ts Outdated Show resolved Hide resolved
@Shinigami92 Shinigami92 merged commit ff54abb into faker-js:main Feb 5, 2022
demipel8 pushed a commit to demipel8/faker that referenced this pull request Mar 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants