Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: rewrite random #490

Merged
merged 2 commits into from
Feb 15, 2022
Merged

test: rewrite random #490

merged 2 commits into from
Feb 15, 2022

Conversation

Shinigami92
Copy link
Member

No description provided.

@Shinigami92 Shinigami92 requested a review from a team as a code owner February 14, 2022 17:56
@Shinigami92 Shinigami92 self-assigned this Feb 14, 2022
@codecov
Copy link

codecov bot commented Feb 14, 2022

Codecov Report

Merging #490 (f1e3f46) into main (fceb128) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #490      +/-   ##
==========================================
- Coverage   99.34%   99.34%   -0.01%     
==========================================
  Files        1919     1919              
  Lines      176173   176174       +1     
  Branches      904      901       -3     
==========================================
- Hits       175019   175016       -3     
- Misses       1098     1102       +4     
  Partials       56       56              
Impacted Files Coverage Δ
src/random.ts 99.35% <100.00%> (-0.22%) ⬇️
src/vendor/unique.ts 95.96% <0.00%> (-1.62%) ⬇️
src/datatype.ts 99.66% <0.00%> (-0.34%) ⬇️

Copy link
Member

@ST-DDT ST-DDT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where are the seeded tests? This test class looks a lot different from the other ones.
Should we really structure this class differently?

@ST-DDT ST-DDT requested a review from a team February 14, 2022 18:10
@Shinigami92
Copy link
Member Author

Where are the seeded tests? This test class looks a lot different from the other ones. Should we really structure this class differently?

Maybe if I have time and will, I can add seeded tests in next few days.
Or in another PR, so at least we can quick-merge this, so we benefit already from the improved variant.

@prisis
Copy link
Member

prisis commented Feb 15, 2022

Im fine if we add the seed later :)

@ST-DDT ST-DDT merged commit 53c1aea into main Feb 15, 2022
@ST-DDT ST-DDT deleted the rewrite-random-test branch February 15, 2022 15:00
demipel8 pushed a commit to demipel8/faker that referenced this pull request Mar 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants