Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: rewrite finance iban #515

Merged
merged 4 commits into from
Feb 19, 2022
Merged

test: rewrite finance iban #515

merged 4 commits into from
Feb 19, 2022

Conversation

Shinigami92
Copy link
Member

No description provided.

@Shinigami92 Shinigami92 self-assigned this Feb 19, 2022
@codecov
Copy link

codecov bot commented Feb 19, 2022 •
edited
Loading

Codecov Report

Merging #515 (453eed8) into main (c4da9c0) will increase coverage by 0.00%.
The diff coverage is n/a.

❗ Current head 453eed8 differs from pull request most recent head 51f0f27. Consider uploading reports for the commit 51f0f27 to get more accurate results

@@           Coverage Diff           @@
##             main     #515   +/-   ##
=======================================
  Coverage   99.34%   99.34%           
=======================================
  Files        1919     1919           
  Lines      176333   176333           
  Branches      904      906    +2     
=======================================
+ Hits       175176   175178    +2     
+ Misses       1101     1099    -2     
  Partials       56       56
Impacted Files Coverage Δ
src/vendor/unique.ts 97.58% <0.00%> (+1.61%) ⬆️

@Shinigami92 Shinigami92 marked this pull request as ready for review February 19, 2022 18:13
@Shinigami92 Shinigami92 requested a review from a team as a code owner February 19, 2022 18:13
@Shinigami92 Shinigami92 mentioned this pull request Feb 19, 2022
Closed
@ST-DDT
Copy link
Member

ST-DDT commented Feb 19, 2022

No seeded runs?

@ST-DDT ST-DDT requested a review from a team February 19, 2022 19:28
@Shinigami92
Copy link
Member Author

No seeded runs?

I'm not sure if needed, this is a sub-test instead of like the others works
We have seeded already here:

faker/test/finance.spec.ts

Line 21 in 431c108

iban: 'GT30Y75110867098F1E3542612J4',

@ST-DDT ST-DDT merged commit a57223e into main Feb 19, 2022
@ST-DDT ST-DDT deleted the test-rewrite-finance-iban branch February 19, 2022 21:52
demipel8 pushed a commit to demipel8/faker that referenced this pull request Mar 11, 2022
@Shinigami92 @demipel8
test: rewrite finance iban (faker-js#515)
58e3c46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prisis prisis prisis approved these changes

@ST-DDT ST-DDT ST-DDT approved these changes

Assignees

@Shinigami92 Shinigami92

Labels
c: test
Projects
None yet
Milestone
v6.0 - Ensure Project Foundation
Development

Successfully merging this pull request may close these issues.
3 participants
@Shinigami92 @ST-DDT @prisis