Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add some en locale city prefixes and suffixes #685

Merged
merged 3 commits into from
Apr 5, 2022
Merged

feat: add some en locale city prefixes and suffixes #685

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e7eef22
feat: add en locale city prefixes and suffixes
ejcheng Mar 26, 2022
f65c914
test: update tests to match new data
ejcheng Mar 26, 2022
9ceccb9
Merge branch 'main' into feat_en_prefix_suffix
Shinigami92 Apr 5, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion src/locales/en/address/city_prefix.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,10 @@
export default ['North', 'East', 'West', 'South', 'New', 'Lake', 'Port'];
export default [
'North',
'East',
'West',
'South',
'New',
'Lake',
'Port',
'Fort',
];
Shinigami92 marked this conversation as resolved.
Show resolved Hide resolved
5 changes: 5 additions & 0 deletions src/locales/en/address/city_suffix.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,17 +5,22 @@ export default [
'ville',
'berg',
'burgh',
'boro',
'borough',
'bury',
'view',
'port',
'mouth',
'stad',
'stead',
'furt',
'chester',
'cester',
'mouth',
'fort',
'field',
'haven',
'side',
'shire',
'worth',
];
12 changes: 6 additions & 6 deletions test/address.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ const seededRuns = [
{
seed: 42,
expectations: {
city: 'Lake Valentine',
city: 'Port Valentine',
cityPrefix: 'West',
citySuffix: 'bury',
cityName: 'Gulfport',
Expand Down Expand Up @@ -34,9 +34,9 @@ const seededRuns = [
{
seed: 1337,
expectations: {
city: 'South Carmelo',
cityPrefix: 'East',
citySuffix: 'berg',
city: 'New Carmelo',
cityPrefix: 'West',
citySuffix: 'boro',
cityName: 'Dubuque',
streetName: 'Carmelo Forks',
streetPrefix: 'a',
Expand Down Expand Up @@ -64,8 +64,8 @@ const seededRuns = [
seed: 1211,
expectations: {
city: 'La Crosse',
cityPrefix: 'Port',
citySuffix: 'side',
cityPrefix: 'Fort',
citySuffix: 'shire',
cityName: 'Urbana',
streetName: 'Trantow Via',
streetPrefix: 'c',
Expand Down
8 changes: 4 additions & 4 deletions test/helpers.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ const seededRuns = [
},
],
address: {
city: 'Leopoldbury',
city: 'Leopoldview',
country: 'Aruba',
geo: {
lat: '51.3317',
Expand Down Expand Up @@ -123,7 +123,7 @@ const seededRuns = [
},
userCard: {
address: {
city: 'North Wainochester',
city: 'North Wainomouth',
geo: {
lat: '4.4562',
lng: '-177.4562',
Expand Down Expand Up @@ -396,7 +396,7 @@ const seededRuns = [
},
contextualCard: {
address: {
city: 'Susieville',
city: 'Susieberg',
geo: {
lat: '-88.0651',
lng: '-37.2858',
Expand All @@ -421,7 +421,7 @@ const seededRuns = [
},
userCard: {
address: {
city: 'Reingerfort',
city: 'Reingerfield',
geo: {
lat: '73.0714',
lng: '-108.2073',
Expand Down