Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release: 6.1.1 #716

Merged
merged 4 commits into from
Mar 28, 2022
Merged

release: 6.1.1 #716

merged 4 commits into from
Mar 28, 2022

Conversation

Shinigami92
Copy link
Member

No description provided.

@Shinigami92 Shinigami92 linked an issue Mar 28, 2022 that may be closed by this pull request
Error: Cannot find module '/workspace/tgyi_mysql/node_modules/@faker-js/faker/dist/cjs/index.js' #711
Closed
@Shinigami92 Shinigami92 added the c: release Release label Mar 28, 2022
@Shinigami92 Shinigami92 self-assigned this Mar 28, 2022
@Shinigami92 Shinigami92 added p: 3-urgent Fix and release ASAP s: accepted Accepted feature / Confirmed bug labels Mar 28, 2022
@Shinigami92 Shinigami92 added this to the v6.1 - First bugfixes milestone Mar 28, 2022
@Shinigami92 Shinigami92 marked this pull request as ready for review March 28, 2022 21:03
@Shinigami92 Shinigami92 requested a review from a team as a code owner March 28, 2022 21:03
ST-DDT
ST-DDT previously approved these changes Mar 28, 2022
View reviewed changes
import-brain
import-brain previously approved these changes Mar 28, 2022
View reviewed changes
@ST-DDT ST-DDT mentioned this pull request Mar 28, 2022
Closed
@Shinigami92 @xDivisionByZerox
Apply suggestions from code review
9f98603 
Co-authored-by: Leyla Jähnig <77127505+xDivisionByZerox@users.noreply.github.com>
@Shinigami92 Shinigami92 dismissed stale reviews from import-brain and ST-DDT via 9f98603 March 28, 2022 21:06
@codecov
Copy link

codecov bot commented Mar 28, 2022 •
edited
Loading

Codecov Report

Merging #716 (c655bd9) into main (7d81712) will not change coverage.
The diff coverage is n/a.

❗ Current head c655bd9 differs from pull request most recent head 9f98603. Consider uploading reports for the commit 9f98603 to get more accurate results

@@           Coverage Diff           @@
##             main     #716   +/-   ##
=======================================
  Coverage   99.34%   99.34%           
=======================================
  Files        1924     1924           
  Lines      176983   176983           
  Branches      904      904           
=======================================
  Hits       175822   175822           
  Misses       1105     1105           
  Partials       56       56

@ST-DDT ST-DDT requested review from import-brain, ST-DDT, xDivisionByZerox and a team March 28, 2022 21:06
@Shinigami92 Shinigami92 enabled auto-merge (squash) March 28, 2022 21:06
@Shinigami92 Shinigami92 merged commit 62dcfc9 into main Mar 28, 2022
@Shinigami92 Shinigami92 deleted the release-6.1.1 branch March 28, 2022 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xDivisionByZerox xDivisionByZerox xDivisionByZerox approved these changes

@import-brain import-brain import-brain approved these changes

@ST-DDT ST-DDT ST-DDT approved these changes

@pkuczynski pkuczynski pkuczynski approved these changes

Assignees

@Shinigami92 Shinigami92

Labels
c: release Release p: 3-urgent Fix and release ASAP s: accepted Accepted feature / Confirmed bug
Projects
None yet
Milestone
v6.1 - First bugfixes
Development

Successfully merging this pull request may close these issues.

Error: Cannot find module '/workspace/tgyi_mysql/node_modules/@faker-js/faker/dist/cjs/index.js'
5 participants
@Shinigami92 @pkuczynski @ST-DDT @import-brain @xDivisionByZerox