Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: move vendor to utils and update license notes #738

Merged
merged 9 commits into from
Mar 31, 2022
Merged

chore: move vendor to utils and update license notes #738

merged 9 commits into from
Mar 31, 2022

Conversation

pkuczynski
Copy link
Member

Fixes #733

@pkuczynski pkuczynski requested a review from a team as a code owner March 31, 2022 09:54
@pkuczynski pkuczynski mentioned this pull request Mar 31, 2022
Closed
@pkuczynski pkuczynski self-assigned this Mar 31, 2022
@pkuczynski pkuczynski added the c: docs Improvements or additions to documentation label Mar 31, 2022
@pkuczynski pkuczynski added this to the v6.1 - First bugfixes milestone Mar 31, 2022
@codecov
Copy link

codecov bot commented Mar 31, 2022 •
edited
Loading

Codecov Report

Merging #738 (6942c04) into main (2e22845) will increase coverage by 0.00%.
The diff coverage is 96.33%.

❗ Current head 6942c04 differs from pull request most recent head 25953b5. Consider uploading reports for the commit 25953b5 to get more accurate results

@@           Coverage Diff           @@
##             main     #738   +/-   ##
=======================================
  Coverage   99.34%   99.34%           
=======================================
  Files        1924     1924           
  Lines      177022   177016    -6     
  Branches      904      904           
=======================================
+ Hits       175861   175863    +2     
+ Misses       1105     1097    -8     
  Partials       56       56
Impacted Files Coverage Δ
src/utils/unique.ts 95.16% <ø> (ø)
src/utils/mersenne.ts 95.93% <95.93%> (ø)
src/internet.ts 100.00% <100.00%> (ø)
src/mersenne.ts 100.00% <100.00%> (ø)
src/unique.ts 100.00% <100.00%> (ø)
src/utils/user-agent.ts 97.84% <100.00%> (ø)

Shinigami92
Shinigami92 requested changes Mar 31, 2022
View reviewed changes
src/utils/mersenne.ts Outdated Show resolved Hide resolved
src/utils/mersenne.ts Outdated Show resolved Hide resolved
src/utils/user-agent.ts Outdated Show resolved Hide resolved
src/utils/user-agent.ts Outdated Show resolved Hide resolved
src/utils/user-agent.ts Outdated Show resolved Hide resolved
@pkuczynski pkuczynski requested review from a team March 31, 2022 11:16
pkuczynski and others added 2 commits March 31, 2022 13:22
@pkuczynski @Shinigami92
Apply suggestions from code review
814c017 
Co-authored-by: Shinigami <chrissi92@hotmail.de>
@pkuczynski
chore: remove accidential jsdoc
3f1a321
Shinigami92
Shinigami92 requested changes Mar 31, 2022
View reviewed changes
src/utils/user-agent.ts Outdated Show resolved Hide resolved
src/utils/user-agent.ts Outdated Show resolved Hide resolved
import-brain
import-brain reviewed Mar 31, 2022
View reviewed changes
src/utils/mersenne.ts Outdated Show resolved Hide resolved
import-brain
import-brain reviewed Mar 31, 2022
View reviewed changes
src/utils/mersenne.ts Outdated Show resolved Hide resolved
@import-brain import-brain added c: chore PR that doesn't affect the runtime behavior p: 1-normal Nothing urgent labels Mar 31, 2022
pkuczynski and others added 2 commits March 31, 2022 16:39
@pkuczynski @import-brain
Update src/utils/mersenne.ts
d48847c 
Co-authored-by: Eric Cheng <ericcheng9316@gmail.com>
@pkuczynski @import-brain
Update src/utils/mersenne.ts
5103c3c 
Co-authored-by: Eric Cheng <ericcheng9316@gmail.com>
import-brain
import-brain previously approved these changes Mar 31, 2022
View reviewed changes
@pkuczynski pkuczynski requested review from Shinigami92, import-brain and a team March 31, 2022 17:02
@Shinigami92 Shinigami92 enabled auto-merge (squash) March 31, 2022 17:10
@Shinigami92
Copy link
Member

nice cleanup 👍

@Shinigami92 Shinigami92 merged commit 0b350f9 into main Mar 31, 2022
@ST-DDT ST-DDT deleted the vendor-to-utils branch March 31, 2022 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@import-brain import-brain import-brain approved these changes

@Shinigami92 Shinigami92 Shinigami92 approved these changes

Assignees

@pkuczynski pkuczynski

Labels
c: chore PR that doesn't affect the runtime behavior c: docs Improvements or additions to documentation p: 1-normal Nothing urgent
Projects
None yet
Milestone
v6.1 - First bugfixes
Development

Successfully merging this pull request may close these issues.
3 participants
@pkuczynski @Shinigami92 @import-brain