feat: migrate fake #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
HonzaMac
reviewed
Jan 11, 2022
27 tasks
Shinigami92
force-pushed
the
migrate-to-typescript
branch
from
0e7e1ba to
64b8db8
Compare
Shinigami92
force-pushed
the
migrate-fake
branch
from
4a3dd6c to
3dc59e3
Compare
Shinigami92
force-pushed
the
migrate-to-typescript
branch
2 times, most recently
from
24a00c3 to
3db7e8b
Compare
Shinigami92
force-pushed
the
migrate-fake
branch
from
3dc59e3 to
79f64a1
Compare
Shinigami92
force-pushed
the
migrate-to-typescript
branch
from
fc36e2f to
7b02094
Compare
Merged
prisis
reviewed
Jan 13, 2022
| return str; | ||
| } | ||
|
|
||
| // console.log('attempting to parse', str); |
There was a problem hiding this comment.
This should be removed, this will not break anything
prisis
reviewed
Jan 13, 2022
| const token = str.substr(start + 2, end - start - 2); | ||
| let method = token.replace('}}', '').replace('{{', ''); | ||
|
|
||
| // console.log('method', method) |
There was a problem hiding this comment.
This should be removed, this will not break anything
prisis
approved these changes
Jan 13, 2022
Shinigami92
force-pushed
the
migrate-fake
branch
from
79f64a1 to
3992ff4
Compare
Co-authored-by: Honza Machala <honza.machala@seznam.cz>
Shinigami92
force-pushed
the
migrate-fake
branch
from
3992ff4 to
830fc0e
Compare
Shinigami92
added a commit
that referenced
this pull request
Jan 14, 2022
Co-authored-by: Honza Machala <honza.machala@seznam.cz>
Shinigami92
added a commit
that referenced
this pull request
Jan 14, 2022
Co-authored-by: Honza Machala <honza.machala@seznam.cz>
damienwebdev
pushed a commit
that referenced
this pull request
Jan 14, 2022
Co-authored-by: Honza Machala <honza.machala@seznam.cz>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is based on top of other TS migrations like #72
This module seems to need some other stuff cause it dynamically requests stuff with e.g.
faker[parts[0]][parts[1]]Usually this will request the name module. (#84)
test with
npm run build && npx mocha test/date.unit.js